projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
eb1d23d
)
drm: bridge: document bridge attach/detach imbalance
author
Peter Rosin
<peda@axentia.se>
Mon, 6 Aug 2018 06:19:10 +0000
(08:19 +0200)
committer
Andrzej Hajda
<a.hajda@samsung.com>
Thu, 13 Sep 2018 09:28:12 +0000
(11:28 +0200)
Since commit
4a878c03d562
("drm: bridge: Detach bridge from encoder at
encoder cleanup time"), it is generally no longer correct to detach bridges
from encoders manually. Document that.
Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link:
https://patchwork.freedesktop.org/patch/msgid/20180806061910.29914-3-peda@axentia.se
drivers/gpu/drm/drm_bridge.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/drm_bridge.c
b/drivers/gpu/drm/drm_bridge.c
index
1638bfe
..
ba70250
100644
(file)
--- a/
drivers/gpu/drm/drm_bridge.c
+++ b/
drivers/gpu/drm/drm_bridge.c
@@
-104,6
+104,10
@@
EXPORT_SYMBOL(drm_bridge_remove);
* If non-NULL the previous bridge must be already attached by a call to this
* function.
*
+ * Note that bridges attached to encoders are auto-detached during encoder
+ * cleanup in drm_encoder_cleanup(), so drm_bridge_attach() should generally
+ * *not* be balanced with a drm_bridge_detach() in driver code.
+ *
* RETURNS:
* Zero on success, error code on failure
*/