Bluetooth: ecdh_helper - fix leak of private key
authorTudor Ambarus <tudor.ambarus@microchip.com>
Thu, 28 Sep 2017 14:14:54 +0000 (17:14 +0300)
committerMarcel Holtmann <marcel@holtmann.org>
Fri, 6 Oct 2017 18:35:47 +0000 (20:35 +0200)
tmp buffer contains the swapped private key. In case the setkey call
failed, the tmp buffer was freed without clearing the private key.

Zeroize the temporary buffer so we don't leak the private key.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/ecdh_helper.c

index 22c8daa..16e022f 100644 (file)
@@ -122,7 +122,7 @@ free_all:
 free_req:
        kpp_request_free(req);
 free_tmp:
-       kfree(tmp);
+       kzfree(tmp);
        return err;
 }