tty: serial: jsm: remove redundant assignments to variable linestatus
authorColin Ian King <colin.i.king@gmail.com>
Mon, 7 Mar 2022 15:30:47 +0000 (15:30 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Mar 2022 12:14:47 +0000 (13:14 +0100)
Variable linestatus is being assigned values that are never read, the
assignments are redundant and can be removed.

Cleans up clang scan warnings:
drivers/tty/serial/jsm/jsm_cls.c:369:2: warning: Value stored to
'linestatus' is never read [deadcode.DeadStores]
drivers/tty/serial/jsm/jsm_cls.c:400:4: warning: Value stored to
'linestatus' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20220307153047.139639-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/jsm/jsm_cls.c

index b280da5..444f233 100644 (file)
@@ -350,7 +350,7 @@ static void cls_assert_modem_signals(struct jsm_channel *ch)
 static void cls_copy_data_from_uart_to_queue(struct jsm_channel *ch)
 {
        int qleft = 0;
-       u8 linestatus = 0;
+       u8 linestatus;
        u8 error_mask = 0;
        u16 head;
        u16 tail;
@@ -365,8 +365,6 @@ static void cls_copy_data_from_uart_to_queue(struct jsm_channel *ch)
        head = ch->ch_r_head & RQUEUEMASK;
        tail = ch->ch_r_tail & RQUEUEMASK;
 
-       /* Get our cached LSR */
-       linestatus = ch->ch_cached_lsr;
        ch->ch_cached_lsr = 0;
 
        /* Store how much space we have left in the queue */