ice: Don't allow same value for Rx tail to be written twice
authorBrett Creeley <brett.creeley@intel.com>
Thu, 6 Feb 2020 09:20:02 +0000 (01:20 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 12 Feb 2020 19:48:22 +0000 (11:48 -0800)
Currently we compare the value we are about to write to the Rx tail
register with the previous value of next_to_use. The problem with this
is we only write tail on 8 descriptor boundaries, but next_to_use is
updated whenever we clean Rx descriptors. Fix this by comparing the
value we are about to write to tail with the previously written tail
value. This will prevent duplicate Rx tail bumps.

Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_txrx_lib.c

index 35bbc4f..6da048a 100644 (file)
@@ -10,7 +10,7 @@
  */
 void ice_release_rx_desc(struct ice_ring *rx_ring, u32 val)
 {
-       u16 prev_ntu = rx_ring->next_to_use;
+       u16 prev_ntu = rx_ring->next_to_use & ~0x7;
 
        rx_ring->next_to_use = val;