drm/vc4: Fix TILE_Y_OFFSET definitions
authorEric Anholt <eric@anholt.net>
Fri, 3 Aug 2018 09:22:27 +0000 (11:22 +0200)
committerpopcornmix <popcornmix@gmail.com>
Fri, 9 Aug 2019 16:57:40 +0000 (18:57 +0200)
Y_OFFSET field starts at bit 8 not 7.

Signed-off-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180803092231.26446-1-boris.brezillon@bootlin.com
drivers/gpu/drm/vc4/vc4_regs.h

index d6864fa..ccbd6b3 100644 (file)
@@ -1043,8 +1043,8 @@ enum hvs_pixel_format {
 #define SCALER_PITCH0_TILE_LINE_DIR            BIT(15)
 #define SCALER_PITCH0_TILE_INITIAL_LINE_DIR    BIT(14)
 /* Y offset within a tile. */
-#define SCALER_PITCH0_TILE_Y_OFFSET_MASK       VC4_MASK(13, 7)
-#define SCALER_PITCH0_TILE_Y_OFFSET_SHIFT      7
+#define SCALER_PITCH0_TILE_Y_OFFSET_MASK       VC4_MASK(13, 8)
+#define SCALER_PITCH0_TILE_Y_OFFSET_SHIFT      8
 #define SCALER_PITCH0_TILE_WIDTH_R_MASK                VC4_MASK(6, 0)
 #define SCALER_PITCH0_TILE_WIDTH_R_SHIFT       0