mtd: rawnand: ingenic: Add of_node_put() before return
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Tue, 9 Jul 2019 17:20:30 +0000 (22:50 +0530)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 25 Jul 2019 12:21:44 +0000 (14:21 +0200)
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c

index d7b7c0f..df214e7 100644 (file)
@@ -418,6 +418,7 @@ static int ingenic_nand_init_chips(struct ingenic_nfc *nfc,
                ret = ingenic_nand_init_chip(pdev, nfc, np, i);
                if (ret) {
                        ingenic_nand_cleanup_chips(nfc);
+                       of_node_put(np);
                        return ret;
                }