ASoC: atmel: atmel_wm8904: consider CPU-Platform possibility unnecessary Platform"
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 28 Jun 2019 01:46:37 +0000 (10:46 +0900)
committerMark Brown <broonie@kernel.org>
Fri, 28 Jun 2019 14:10:01 +0000 (15:10 +0100)
commit 3609750e9d4ba9db ("ASoC: atmel: atmel_wm8904: don't select
unnecessary Platform")

Current ALSA SoC avoid to add duplicate component to rtd,
and this driver was selecting CPU component as Platform component.
Thus, above patch removed Platform settings from this driver,
because it assumed these are same component.

But, some CPU driver is using generic DMAEngine, in such case, both
CPU component and Platform component will have same of_node/name.
In other words, there are some components which are different but
have same of_node/name.

In such case, Card driver definitely need to select Platform even
though it is same as CPU.
It is depends on CPU driver, but is difficult to know it from Card driver.
This patch reverts above patch.

Fixes: commit 3609750e9d4ba9db ("ASoC: atmel: atmel_wm8904: don't select unnecessary Platform")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/atmel/atmel_wm8904.c

index 84e5e5da56196872f04d593927c603e6611b9820..776b27d3686e72ab2071468eb36bb7afa6adec92 100644 (file)
@@ -58,7 +58,8 @@ static const struct snd_soc_ops atmel_asoc_wm8904_ops = {
 
 SND_SOC_DAILINK_DEFS(pcm,
        DAILINK_COMP_ARRAY(COMP_EMPTY()),
-       DAILINK_COMP_ARRAY(COMP_CODEC(NULL, "wm8904-hifi")));
+       DAILINK_COMP_ARRAY(COMP_CODEC(NULL, "wm8904-hifi")),
+       DAILINK_COMP_ARRAY(COMP_EMPTY()));
 
 static struct snd_soc_dai_link atmel_asoc_wm8904_dailink = {
        .name = "WM8904",
@@ -112,6 +113,7 @@ static int atmel_asoc_wm8904_dt_init(struct platform_device *pdev)
                return ret;
        }
        dailink->cpus->of_node = cpu_np;
+       dailink->platforms->of_node = cpu_np;
        of_node_put(cpu_np);
 
        codec_np = of_parse_phandle(np, "atmel,audio-codec", 0);