Fix issue dotnet/coreclr#20076 createdump faults. (dotnet/coreclr#20084)

Return E_FAIL instead of S_FALSE from ClrDataFrame::GetLocalSig().

Also issue https://github.com/dotnet/diagnostics/issues/61

Commit migrated from https://github.com/dotnet/coreclr/commit/f1cf6e7172ae0f0fc3c4617c810d71c514c5e0ba

diff --git a/src/coreclr/src/debug/daccess/stack.cpp b/src/coreclr/src/debug/daccess/stack.cpp
index b235366..2f69a02 100644 (file)
--- a/src/coreclr/src/debug/daccess/stack.cpp
+++ b/src/coreclr/src/debug/daccess/stack.cpp
@@ -1257,7 +1257,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig,
         {
             *sig = NULL;
             *count = 0;
-            return S_FALSE;
+            return E_FAIL;
         }
 
         COR_ILMETHOD_DECODER methodDecoder(m_methodDesc->GetILHeader());
@@ -1267,7 +1267,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig,
         {
             *sig = NULL;
             *count = 0;
-            return S_FALSE;
+            return E_FAIL;
         }
 
         ULONG tokenSigLen;