staging: wilc1000: remove 'if' on field address
authorDafna Hirschfeld <dafna3@gmail.com>
Thu, 22 Feb 2018 07:10:12 +0000 (09:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Feb 2018 13:53:05 +0000 (14:53 +0100)
Remove 'if' statements testing struct's field address.
Since such statements always return true, they are redundant.

Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/linux_wlan.c

index d9725ef..cf746f2 100644 (file)
@@ -628,8 +628,7 @@ void wilc1000_wlan_deinit(struct net_device *dev)
                        wl->hif_func->disable_interrupt(wl);
                        mutex_unlock(&wl->hif_cs);
                }
-               if (&wl->txq_event)
-                       complete(&wl->txq_event);
+               complete(&wl->txq_event);
 
                wlan_deinitialize_threads(dev);
                deinit_irq(dev);
@@ -677,11 +676,8 @@ static int wlan_deinit_locks(struct net_device *dev)
        vif = netdev_priv(dev);
        wilc = vif->wilc;
 
-       if (&wilc->hif_cs)
-               mutex_destroy(&wilc->hif_cs);
-
-       if (&wilc->rxq_cs)
-               mutex_destroy(&wilc->rxq_cs);
+       mutex_destroy(&wilc->hif_cs);
+       mutex_destroy(&wilc->rxq_cs);
 
        return 0;
 }
@@ -716,8 +712,7 @@ static void wlan_deinitialize_threads(struct net_device *dev)
 
        wl->close = 1;
 
-       if (&wl->txq_event)
-               complete(&wl->txq_event);
+       complete(&wl->txq_event);
 
        if (wl->txq_thread) {
                kthread_stop(wl->txq_thread);