clk: mediatek: clk-mt7629-eth: Add check for mtk_alloc_clk_data
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Tue, 12 Sep 2023 09:34:06 +0000 (17:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:59:06 +0000 (11:59 +0100)
[ Upstream commit 0884393c63cc9a1772f7121a6645ba7bd76feeb9 ]

Add the check for the return value of mtk_alloc_clk_data() in order to
avoid NULL pointer dereference.

Fixes: 3b5e748615e7 ("clk: mediatek: add clock support for MT7629 SoC")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20230912093407.21505-4-jiasheng@iscas.ac.cn
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/mediatek/clk-mt7629-eth.c

index fe714de..1bfedc9 100644 (file)
@@ -77,6 +77,8 @@ static int clk_mt7629_ethsys_init(struct platform_device *pdev)
        int r;
 
        clk_data = mtk_alloc_clk_data(CLK_ETH_NR_CLK);
+       if (!clk_data)
+               return -ENOMEM;
 
        mtk_clk_register_gates(&pdev->dev, node, eth_clks,
                               CLK_ETH_NR_CLK, clk_data);
@@ -100,6 +102,8 @@ static int clk_mt7629_sgmiisys_init(struct platform_device *pdev)
        int r;
 
        clk_data = mtk_alloc_clk_data(CLK_SGMII_NR_CLK);
+       if (!clk_data)
+               return -ENOMEM;
 
        mtk_clk_register_gates(&pdev->dev, node, sgmii_clks[id++],
                               CLK_SGMII_NR_CLK, clk_data);