ASoC: rt715: Add power-up delay to fix dmic pop sound issue.
authorJack Yu <jack.yu@realtek.com>
Fri, 25 Sep 2020 21:05:09 +0000 (16:05 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 28 Sep 2020 16:59:02 +0000 (17:59 +0100)
Add 400ms power-up delay recommended to fix pop noise on capture.

Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
Signed-off-by: Jack Yu <jack.yu@realtek.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200925210509.83353-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt715.c
sound/soc/codecs/rt715.h

index 099c8bd..532c530 100644 (file)
@@ -9,7 +9,6 @@
  */
 
 #include <linux/module.h>
-#include <linux/moduleparam.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/delay.h>
@@ -498,6 +497,7 @@ static int rt715_set_bias_level(struct snd_soc_component *component,
                        regmap_write(rt715->regmap,
                                                RT715_SET_AUDIO_POWER_STATE,
                                                AC_PWRST_D0);
+                       msleep(RT715_POWER_UP_DELAY_MS);
                }
                break;
 
index df0f24f..d0d0fd2 100644 (file)
@@ -210,6 +210,8 @@ enum {
        RT715_AIFS,
 };
 
+#define RT715_POWER_UP_DELAY_MS 400
+
 int rt715_io_init(struct device *dev, struct sdw_slave *slave);
 int rt715_init(struct device *dev, struct regmap *sdw_regmap,
        struct regmap *regmap, struct sdw_slave *slave);