virtio_vdpa: don't warn when fail to disable vq
authorJason Wang <jasowang@redhat.com>
Mon, 4 Jan 2021 06:55:02 +0000 (14:55 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 23 Feb 2021 12:52:58 +0000 (07:52 -0500)
There's no guarantee that the device can disable a specific virtqueue
through set_vq_ready(). One example is the modern virtio-pci
device. So this patch removes the warning.

Signed-off-by: Jason Wang <jasowang@redhat.com>
Link: https://lore.kernel.org/r/20210104065503.199631-19-jasowang@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/virtio/virtio_vdpa.c

index 4a9ddb4..e28acf4 100644 (file)
@@ -225,9 +225,8 @@ static void virtio_vdpa_del_vq(struct virtqueue *vq)
        list_del(&info->node);
        spin_unlock_irqrestore(&vd_dev->lock, flags);
 
-       /* Select and deactivate the queue */
+       /* Select and deactivate the queue (best effort) */
        ops->set_vq_ready(vdpa, index, 0);
-       WARN_ON(ops->get_vq_ready(vdpa, index));
 
        vring_del_virtqueue(vq);