net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

Here, If devm_ioremap will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference.
This error check will avoid NULL pointer dereference.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
index 16e12c45904be6d4a24b858d5f4265a78adbc3d9..21f80f5744ba2f048b4d7e0a8a8862e45977a339 100644 (file)
--- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
+++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
@@ -1469,6 +1469,12 @@ static int octeon_mgmt_probe(struct platform_device *pdev)
        p->agl = (u64)devm_ioremap(&pdev->dev, p->agl_phys, p->agl_size);
        p->agl_prt_ctl = (u64)devm_ioremap(&pdev->dev, p->agl_prt_ctl_phys,
                                           p->agl_prt_ctl_size);
+       if (!p->mix || !p->agl || !p->agl_prt_ctl) {
+               dev_err(&pdev->dev, "failed to map I/O memory\n");
+               result = -ENOMEM;
+               goto err;
+       }
+
        spin_lock_init(&p->lock);
 
        skb_queue_head_init(&p->tx_list);