ASoC: codecs: rt1019: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mon, 26 Apr 2021 21:47:00 +0000 (16:47 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 10 May 2021 12:05:29 +0000 (13:05 +0100)
cppcheck warning, add parentheses:

sound/soc/codecs/rt1019.c:375:61: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
  (pll_code.m_bp ? 0 : pll_code.m_code) << RT1019_PLL_M_SFT |
                                                            ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210426214701.235106-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt1019.c

index 10656a5..1ed85ec 100644 (file)
@@ -372,8 +372,8 @@ static int rt1019_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
                RT1019_AUTO_BITS_SEL_MANU | RT1019_AUTO_CLK_SEL_MANU);
        snd_soc_component_update_bits(component, RT1019_PLL_1,
                RT1019_PLL_M_MASK | RT1019_PLL_M_BP_MASK | RT1019_PLL_Q_8_8_MASK,
-               (pll_code.m_bp ? 0 : pll_code.m_code) << RT1019_PLL_M_SFT |
-               pll_code.m_bp << RT1019_PLL_M_BP_SFT |
+               ((pll_code.m_bp ? 0 : pll_code.m_code) << RT1019_PLL_M_SFT) |
+               (pll_code.m_bp << RT1019_PLL_M_BP_SFT) |
                ((pll_code.n_code >> 8) & RT1019_PLL_Q_8_8_MASK));
        snd_soc_component_update_bits(component, RT1019_PLL_2,
                RT1019_PLL_Q_7_0_MASK, pll_code.n_code & RT1019_PLL_Q_7_0_MASK);