scsi: scsi_debugfs: Use for_each_set_bit to simplify code
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 25 Jul 2019 20:07:51 +0000 (23:07 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 30 Jul 2019 16:42:55 +0000 (12:42 -0400)
We can use for_each_set_bit() to slightly simplify the code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_debugfs.c

index c5a8756..c19ea7a 100644 (file)
@@ -1,4 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
+#include <linux/bitops.h>
 #include <linux/seq_file.h>
 #include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_dbg.h>
@@ -18,9 +19,7 @@ static int scsi_flags_show(struct seq_file *m, const unsigned long flags,
        bool sep = false;
        int i;
 
-       for (i = 0; i < sizeof(flags) * BITS_PER_BYTE; i++) {
-               if (!(flags & BIT(i)))
-                       continue;
+       for_each_set_bit(i, &flags, BITS_PER_LONG) {
                if (sep)
                        seq_puts(m, "|");
                sep = true;