Fix bug unrefing connection too early in check_hello_message().
authorRalf Habacker <ralf.habacker@freenet.de>
Fri, 6 Nov 2015 13:02:29 +0000 (14:02 +0100)
committerRalf Habacker <ralf.habacker@freenet.de>
Fri, 6 Nov 2015 16:53:29 +0000 (17:53 +0100)
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92721
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
bus/dispatch.c

index 3ea944ab1d068c35a5765ca878c4b1e7cc63d5e5..ae7ac38592be5a8d988c433437f88099cc945a19 100644 (file)
@@ -941,8 +941,6 @@ check_hello_message (BusContext     *context,
       return TRUE;
     }
 
-  dbus_connection_unref (connection);
-
   message = pop_message_waiting_for_memory (connection);
   if (message == NULL)
     {
@@ -1090,6 +1088,8 @@ check_hello_message (BusContext     *context,
   if (name_message)
     dbus_message_unref (name_message);
 
+  dbus_connection_unref (connection);
+
   return retval;
 }