Fix cynara check

smack_new_label_from_self() returns length of label, not error code.

Change-Id: I3b9fc509886a2eec4732da00d0da334744bdbf40

diff --git a/src/common/extension.cc b/src/common/extension.cc
index 33ca4565eebaaa7b25c449bce889d8edfd9bddf6..c4979f572c2759a2c7d0098bba20030ea4422c2c 100755 (executable)
--- a/src/common/extension.cc
+++ b/src/common/extension.cc
@@ -525,9 +525,8 @@ class AccessControlImpl {
     LoggerD("Privilege access checked using Cynara.");
 
     char* smack_label = nullptr;
-    int ret = smack_new_label_from_self(&smack_label);
-
-    if (0 == ret && nullptr != smack_label) {
+    int len = smack_new_label_from_self(&smack_label);
+    if (0 < len && nullptr != smack_label) {
       auto uid = getuid();
 
       SLoggerD("uid: [%u]", uid);
@@ -542,7 +541,7 @@ class AccessControlImpl {
       return;
     }
 
-    ret = cynara_initialize(&cynara_, nullptr);
+    int ret = cynara_initialize(&cynara_, nullptr);
     if (CYNARA_API_SUCCESS != ret) {
       LoggerE("Failed to initialize Cynara");
       cynara_ = nullptr;