Deprecate non-ewk api usages in app.c
authorSeungSeop Park <sns.park@samsung.com>
Thu, 26 Feb 2015 13:35:13 +0000 (22:35 +0900)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 06:57:09 +0000 (06:57 +0000)
In following commit, only ewk_ prefixed symbol will be exported.
To avoid build break, this patch comments out the code using
unexported symbols such as FOR_TESTING_ewk_hit_test_*.

TODO: replace this with proper solution.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11609
Reviewed by: Antonio Gomes, Janusz Majnert

Change-Id: I6f4c9afe5d9048c6658e18a7f2090990a9e87c3a
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
tizen_src/ewk/chromium-ewk.gyp
tizen_src/ewk/efl_webview_app/app.c

index 72167c2..89fd0f5 100644 (file)
         '-lchromium-ewk',
       ],
     },
+    'conditions': [
+      ['ewk_bringup==1', {
+        'defines': [ 'EWK_BRINGUP=1' ],
+      }]
+    ]
   },
 
   {
index 28c2036..b433036 100644 (file)
@@ -1380,8 +1380,10 @@ void __hit_test_request_cb(Evas_Object* o, int x, int y, int hit_test_mode, Ewk_
   printf("HitTest: tag name %s\n", ewk_hit_test_tag_name_get(ht));
   printf("HitTest: node value %s\n", ewk_hit_test_node_value_get(ht));
   printf("HitTest: image length %d\n", ewk_hit_test_image_buffer_length_get(ht));
+#if !defined(EWK_BRINGUP)
   printf("HitTest: height of image %d\n", FOR_TESTING_ewk_hit_test_image_height_get(ht));
   printf("HitTest: height of image %d\n", FOR_TESTING_ewk_hit_test_image_width_get(ht));
+#endif
   printf("HitTest: filename extension %s\n", ewk_hit_test_image_file_name_extension_get(ht));
   if (ewk_hit_test_image_buffer_length_get(ht)) {
     // To verify the buffer, we write to file.
@@ -1389,9 +1391,11 @@ void __hit_test_request_cb(Evas_Object* o, int x, int y, int hit_test_mode, Ewk_
     Evas_Object* image = evas_object_image_add(e);
     evas_object_image_colorspace_set(image, EVAS_COLORSPACE_ARGB8888);
     evas_object_image_alpha_set(image, EINA_TRUE);
+#if !defined(EWK_BRINGUP)
     evas_object_image_size_set(image,
         FOR_TESTING_ewk_hit_test_image_width_get(ht),
         FOR_TESTING_ewk_hit_test_image_height_get(ht));
+#endif
     evas_object_image_data_copy_set(image, ewk_hit_test_image_buffer_get(ht));
     static char filename_buffer[256];
     static int count = 1;