Fix repeat builds with Android.
authorbungeman <bungeman@google.com>
Fri, 31 Jul 2015 13:33:21 +0000 (06:33 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 31 Jul 2015 13:33:21 +0000 (06:33 -0700)
Currently the SampleApp and VisualBench builds for Android don't work
for rebuilds. The code is re-built, but the apks are not. This
results from the use of a directory as 'output' and the action to
build the apk not depending on the copied libraries.

Review URL: https://codereview.chromium.org/1270643005

platform_tools/android/gyp/skia_android.gypi

index 18de589..48908cb 100644 (file)
             '<(android_base)/apps/sample_app/src/main/java/com/skia/SkiaSampleActivity.java',
             '<(android_base)/apps/sample_app/src/main/java/com/skia/SkiaSampleRenderer.java',
             '<(android_base)/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java',
+            '<(android_base)/apps/sample_app/src/main/libs/<(android_arch)/libSampleApp.so',
+          ],
+          'conditions': [
+            [ 'skia_shared_lib', {
+              'inputs': [
+                '<(android_base)/apps/sample_app/src/main/libs/<(android_arch)/libskia_android.so',
+              ],
+            }],
           ],
           'outputs': [
-            '<(android_base)/apps/sample_app/build',
+            '<(android_base)/apps/sample_app/build/outputs/apk/sample_app-arm-debug.apk',
           ],
           'action': [
             '<(android_base)/apps/gradlew',
           'inputs': [
             '<(android_base)/apps/visualbench/src/main/AndroidManifest.xml',
             '<(android_base)/apps/visualbench/src/main/java/com/skia/VisualBenchActivity.java',
+            '<(android_base)/apps/visualbench/src/main/libs/<(android_arch)/libvisualbench.so',
+          ],
+          'conditions': [
+            [ 'skia_shared_lib', {
+              'inputs': [
+                '<(android_base)/apps/visualbench/src/main/libs/<(android_arch)/libskia_android.so',
+              ],
+            }],
           ],
           'outputs': [
-            '<(android_base)/apps/visualbench/build',
+            '<(android_base)/apps/visualbench/build/outputs/apk/visualbench-arm-debug.apk',
           ],
           'action': [
             '<(android_base)/apps/gradlew',