drm/amdkfd: fix dropped interrupt in kfd_int_process_v11
authorGraham Sider <Graham.Sider@amd.com>
Fri, 23 Sep 2022 14:07:15 +0000 (10:07 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 29 Sep 2022 13:41:44 +0000 (09:41 -0400)
Shader wave interrupts were getting dropped in event_interrupt_wq_v11
if the PRIV bit was set to 1. This would often lead to a hang. Until
debugger logic is upstreamed, expand comment to stop early return.

Signed-off-by: Graham Sider <Graham.Sider@amd.com>
Reviewed-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c

index a6fcbee..0d53f60 100644 (file)
@@ -350,11 +350,11 @@ static void event_interrupt_wq_v11(struct kfd_dev *dev,
                                print_sq_intr_info_inst(context_id0, context_id1);
                                sq_int_priv = REG_GET_FIELD(context_id0,
                                                SQ_INTERRUPT_WORD_WAVE_CTXID0, PRIV);
-                               if (sq_int_priv /*&& (kfd_set_dbg_ev_from_interrupt(dev, pasid,
+                               /*if (sq_int_priv && (kfd_set_dbg_ev_from_interrupt(dev, pasid,
                                                KFD_CTXID0_DOORBELL_ID(context_id0),
                                                KFD_CTXID0_TRAP_CODE(context_id0),
-                                               NULL, 0))*/)
-                                       return;
+                                               NULL, 0)))
+                                       return;*/
                                break;
                        case SQ_INTERRUPT_WORD_ENCODING_ERROR:
                                print_sq_intr_info_error(context_id0, context_id1);