Remove duplicated function
authorMikhail Aksenov <m.aksenov@samsung.com>
Tue, 1 Oct 2019 14:18:20 +0000 (17:18 +0300)
committer이형주/Common Platform Lab(SR)/Staff Engineer/삼성전자 <leee.lee@samsung.com>
Thu, 3 Oct 2019 23:36:55 +0000 (08:36 +0900)
src/debug/netcoredbg/frames.cpp

index 1e5fb83a7020bc40f4046132a2e434b6ca1990eb..5eeafa7cef51396d1549fd968fe7f2975a37f27c 100644 (file)
@@ -48,7 +48,7 @@ HRESULT GetThreadsState(ICorDebugController *controller, std::vector<Thread> &th
     return S_OK;
 }
 
-static uint64_t FrameAddr(ICorDebugFrame *pFrame)
+static uint64_t GetFrameAddr(ICorDebugFrame *pFrame)
 {
     CORDB_ADDRESS startAddr = 0;
     CORDB_ADDRESS endAddr = 0;
@@ -100,7 +100,7 @@ HRESULT ManagedDebugger::GetFrameLocation(ICorDebugFrame *pFrame, int threadId,
     stackFrame.clrAddr.ilOffset = ilOffset;
     stackFrame.clrAddr.nativeOffset = nOffset;
 
-    stackFrame.addr = FrameAddr(pFrame);
+    stackFrame.addr = GetFrameAddr(pFrame);
 
     TypePrinter::GetMethodName(pFrame, stackFrame.name);
 
@@ -147,14 +147,6 @@ HRESULT UnwindNativeFrames(ICorDebugThread *pThread, uint64_t startValue, uint64
     return S_OK;
 }
 
-static uint64_t GetFrameAddr(ICorDebugFrame *pFrame)
-{
-    CORDB_ADDRESS startAddr = 0;
-    CORDB_ADDRESS endAddr = 0;
-    pFrame->GetStackRange(&startAddr, &endAddr);
-    return startAddr;
-}
-
 typedef std::function<HRESULT(FrameType,ICorDebugFrame*,NativeFrame*,ICorDebugFunction*)> WalkFramesCallback;
 
 HRESULT StitchInternalFrames(
@@ -419,7 +411,7 @@ HRESULT ManagedDebugger::GetStackTrace(ICorDebugThread *pThread, int startFrame,
         {
             case FrameUnknown:
                 stackFrames.emplace_back(threadId, currentFrame, "?");
-                stackFrames.back().addr = FrameAddr(pFrame);
+                stackFrames.back().addr = GetFrameAddr(pFrame);
                 break;
             case FrameNative:
                 stackFrames.emplace_back(threadId, currentFrame, pNative->symbol);
@@ -429,7 +421,7 @@ HRESULT ManagedDebugger::GetStackTrace(ICorDebugThread *pThread, int startFrame,
                 break;
             case FrameCLRNative:
                 stackFrames.emplace_back(threadId, currentFrame, "[Native Frame]");
-                stackFrames.back().addr = FrameAddr(pFrame);
+                stackFrames.back().addr = GetFrameAddr(pFrame);
                 break;
             case FrameCLRInternal:
                 {
@@ -441,7 +433,7 @@ HRESULT ManagedDebugger::GetStackTrace(ICorDebugThread *pThread, int startFrame,
                     name += GetInternalTypeName(frameType);
                     name += "]";
                     stackFrames.emplace_back(threadId, currentFrame, name);
-                    stackFrames.back().addr = FrameAddr(pFrame);
+                    stackFrames.back().addr = GetFrameAddr(pFrame);
                 }
                 break;
             case FrameCLRManaged: