Fix coverty defects (CHECKED_RETURN) 99/226999/2 accepted/tizen/unified/20200310.151112 submit/tizen/20200309.034736 submit/tizen/20200309.095617
authorSeungbae Shin <seungbae.shin@samsung.com>
Mon, 9 Mar 2020 03:01:40 +0000 (12:01 +0900)
committerSeungbae Shin <seungbae.shin@samsung.com>
Mon, 9 Mar 2020 03:22:24 +0000 (12:22 +0900)
[Version] 13.0.2
[Issue Type] Vulnerability

Change-Id: Ifc9ef1f508155b34c06a8b14b5cd27fde67ae35d

packaging/pulseaudio-modules-tizen.spec
src/device-manager-dbus.c
src/stream-manager-filter.c

index 769b862..236c429 100644 (file)
@@ -1,6 +1,6 @@
 Name:             pulseaudio-modules-tizen
 Summary:          Pulseaudio modules for Tizen
-Version:          13.0.2
+Version:          13.0.3
 Release:          0
 Group:            Multimedia/Audio
 License:          LGPL-2.1+
index 5e00a25..b9ab071 100644 (file)
@@ -649,10 +649,9 @@ static int method_call_bt_get_name(DBusConnection *conn, const char *device_path
         return -1;
     }
 
-    dbus_message_append_args(msg,
-                DBUS_TYPE_STRING, &intf,
-                DBUS_TYPE_STRING, &prop,
-                DBUS_TYPE_INVALID);
+    pa_assert_se(dbus_message_append_args(msg, DBUS_TYPE_STRING, &intf,
+                                               DBUS_TYPE_STRING, &prop,
+                                               DBUS_TYPE_INVALID));
 
     dbus_error_init(&err);
     if (!(reply = dbus_connection_send_with_reply_and_block(conn, msg, -1, &err))) {
index c954151..8702c58 100644 (file)
@@ -127,8 +127,8 @@ static int32_t control_filter_ladspa(DBusConnection *conn, filter_info *f, uint3
     dbus_message_iter_append_basic(&msg_iter, DBUS_TYPE_STRING, &ladspa_propname);
 
     /* Variant has struct of two arrays, signature : (adab) */
-    dbus_message_iter_open_container(&msg_iter, DBUS_TYPE_VARIANT, "(adab)", &variant_iter);
-    dbus_message_iter_open_container(&variant_iter, DBUS_TYPE_STRUCT, NULL, &struct_iter);
+    pa_assert_se(dbus_message_iter_open_container(&msg_iter, DBUS_TYPE_VARIANT, "(adab)", &variant_iter));
+    pa_assert_se(dbus_message_iter_open_container(&variant_iter, DBUS_TYPE_STRUCT, NULL, &struct_iter));
 
     /* Copying because of the D-Bus type mapping */
     control = pa_xnew(double, f->n_controls);