Exit selection mode upon BACK HW press
authorAntonio Gomes <a1.gomes@samsung.com>
Tue, 1 Dec 2015 21:16:17 +0000 (17:16 -0400)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 07:55:23 +0000 (07:55 +0000)
Hiding selection handles in no enough in order
to exit selection mode upon BACK HW button.
On renderer side, selection will still be active, and
the selection highlight will be still drawn.

Patch fixes this by requesting a "unselecting" text
on the renderer side.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=15083

Reviewed by: a.renevier, djmix.kim

Change-Id: I430c9338f9895ee90a2ce8dc117b170af6c93221
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
tizen_src/ewk/efl_integration/browser/web_view_evas_handler.cc

index a4efd66..c177474 100644 (file)
@@ -48,13 +48,11 @@ bool WebViewEvasEventHandler::HandleEvent_KeyDown(const Evas_Event_Key_Down* eve
     if (webview_->GetContextMenuController()) {
       DVLOG(1) << "Hiding context menu due to back key press";
       webview_->ResetContextMenuController();
-      if (SelectionControllerEfl* selection_controller = webview_->GetSelectionController())
-        selection_controller->HideHandles();
       handled = true;
     }
     if (webview_->GetSelectionController()->IsAnyHandleVisible()) {
       DVLOG(1) << "Clearing text selection due to back key press";
-      webview_->GetSelectionController()->ClearSelection();
+      webview_->GetSelectionController()->ClearSelectionViaEWebView();
       handled = true;
     }
   }