projects
/
platform
/
upstream
/
llvm.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
009ec08
)
[Support] Fix an invalid character escaping in string literal (unittest).
author
Etienne Bergeron
<etienneb@google.com>
Tue, 5 Apr 2016 01:46:26 +0000
(
01:46
+0000)
committer
Etienne Bergeron
<etienneb@google.com>
Tue, 5 Apr 2016 01:46:26 +0000
(
01:46
+0000)
Summary:
A character within a string literal is not escaped correctly.
In this case, there is no semantic change because the invalid character turn out to be NUL anyway.
note: "\0x12" is equivalent to {0, 'x', '1', '2'} and not { 12 }.
This issue was found by clang-tidy.
Reviewers: rnk
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D18747
llvm-svn: 265376
llvm/unittests/Support/Path.cpp
patch
|
blob
|
history
diff --git
a/llvm/unittests/Support/Path.cpp
b/llvm/unittests/Support/Path.cpp
index
1653ac0
..
20e0872
100644
(file)
--- a/
llvm/unittests/Support/Path.cpp
+++ b/
llvm/unittests/Support/Path.cpp
@@
-725,7
+725,7
@@
const char coff_bigobj[] = "\x00\x00\xff\xff\x00\x02......"
const char coff_import_library[] = "\x00\x00\xff\xff....";
const char elf_relocatable[] = { 0x7f, 'E', 'L', 'F', 1, 2, 1, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 1 };
-const char macho_universal_binary[] = "\xca\xfe\xba\xbe...\
0
x00";
+const char macho_universal_binary[] = "\xca\xfe\xba\xbe...\x00";
const char macho_object[] =
"\xfe\xed\xfa\xce........\x00\x00\x00\x01............";
const char macho_executable[] =