projects / platform / upstream / qtmultimedia.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: feaa557)
Fix SourceResolver::State object leak
authorLiang Jian <jianliang79@gmail.com>
Tue, 1 Apr 2014 08:12:48 +0000 (16:12 +0800)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Tue, 1 Apr 2014 16:40:32 +0000 (18:40 +0200)
Initialize m_cRef to 0 in constructor of SourceResolver::State, otherwise
it will be leaked

Change-Id: I703ef8e91ad88112102ede7e8321d0eca795b840
Reviewed-by: Yoann Lopes <yoann.lopes@digia.com>
src/plugins/wmf/sourceresolver.cpp patch | blob | history

diff --git a/src/plugins/wmf/sourceresolver.cpp b/src/plugins/wmf/sourceresolver.cpp
index 9ac126b..57da122 100644 (file)
--- a/src/plugins/wmf/sourceresolver.cpp
+++ b/src/plugins/wmf/sourceresolver.cpp
@@ -278,7 +278,7 @@ IMFMediaSource* SourceResolver::mediaSource() const
 
 /////////////////////////////////////////////////////////////////////////////////
 SourceResolver::State::State(IMFSourceResolver *sourceResolver, bool fromStream)
-    : m_cRef(1)
+    : m_cRef(0)
     , m_sourceResolver(sourceResolver)
     , m_fromStream(fromStream)
 {
Domain: UI Framework / Qt;