Remove unnecessary codes, add default operations and use chrono 95/243095/1
authorYu <jiung.yu@samsung.com>
Thu, 3 Sep 2020 05:28:23 +0000 (14:28 +0900)
committerYu <jiung.yu@samsung.com>
Thu, 3 Sep 2020 05:28:42 +0000 (14:28 +0900)
Change-Id: I7715259785358a590226abe06bc94840e9bf77ea
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
22 files changed:
include/GdbusError.h
include/LocationManager.h
include/MethodHandler.h [deleted file]
include/MqttContext.h
include/Node.h
include/UwbConfig.h
include/UwbDbusIfaceAdapter.h
include/UwbDbusManager.h
include/UwbMqttMessage.h
include/UwbMqttRequest.h
include/UwbNetwork.h
include/UwbPluginManager.h
include/UwbPosition.h
packaging/uwb-manager.spec
src/LocationManager.cpp
src/MqttContext.cpp
src/UwbConfig.cpp
src/UwbDbusIfaceAdapter.cpp
src/UwbMqttMessage.cpp
src/UwbNetwork.cpp
src/UwbPosition.cpp
tests/uwb-manager-gtest.cpp

index 7cf065a234897a471002d274d06babb74601eb56..27d112366135478964762b783577c8fd65bf0720 100644 (file)
@@ -33,16 +33,11 @@ public:
        void setGerror(uwb_error_e error_code, GError **error);
 
 private:
-       const std::string _uwb_quark_str =
-                       std::string("uwb-manager-error-quark");
-       const std::string _invalid_parameter_str =
-                       std::string("org.tizen.uwb.Error.InvalidParameter");
-       const std::string _out_of_memory_str =
-                       std::string("org.tizen.uwb.Error.OutOfMemory");
-       const std::string _permission_denied_str =
-                       std::string("org.tizen.uwb.Error.NotPermitted");
-       const std::string _operation_failed_str =
-                       std::string("org.tizen.uwb.Error.OperationFailed");
+       const std::string _uwb_quark_str{"uwb-manager-error-quark"};
+       const std::string _invalid_parameter_str{"org.tizen.uwb.Error.InvalidParameter"};
+       const std::string _out_of_memory_str{"org.tizen.uwb.Error.OutOfMemory"};
+       const std::string _permission_denied_str{"org.tizen.uwb.Error.NotPermitted"};
+       const std::string _operation_failed_str{"org.tizen.uwb.Error.OperationFailed"};
 };
 
 }
index 425a7ea50a1e13940f90d9a3e9035957e4384f4d..25ab3c70731ee5b53a79faf17aa25faaab9221e7 100644 (file)
@@ -20,6 +20,7 @@
 #include <list>
 #include <map>
 #include <memory>
+#include <chrono>
 
 #include <UwbMqttRequest.h>
 
@@ -56,11 +57,11 @@ public:
 
        /* Warning: getMqttContext should be used only for test purpose */
        MqttContext *getMqttContextPtr() {return _mqtt_context.get();};
-       static constexpr int _position_broadcast_interval = 1;
-       static constexpr int _default_mqtt_qos = 1;
-       static constexpr int _default_remove_duration = 10;
-       static constexpr int _default_tizen_uwb_broadcast_topic_len = 21;
-       static constexpr int _default_tizen_uwb_broadcast_payload_len = 16;
+       static constexpr int _default_mqtt_qos{1};
+       static constexpr int _default_tizen_uwb_broadcast_topic_len{21};
+       static constexpr int _default_tizen_uwb_broadcast_payload_len{16};
+       static constexpr std::chrono::milliseconds _position_broadcast_interval{1000};
+       static constexpr std::chrono::milliseconds _default_remove_duration{10000};
 private:
 
        int tryConnect(void);
diff --git a/include/MethodHandler.h b/include/MethodHandler.h
deleted file mode 100644 (file)
index 27d0027..0000000
+++ /dev/null
@@ -1,40 +0,0 @@
-/*
- * Copyright (c) 2020 Samsung Electronics Co., Ltd.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#ifndef __METHOD_HANDLER_H__
-#define __METHOD_HANDLER_H__
-
-#include <string>
-
-#include <gio/gio.h>
-
-#include "generated-code.h"
-
-#include <uwb-error-def.h>
-
-namespace UwbManagerNamespace {
-
-class MethodHandler {
-
-public:
-       virtual ~MethodHandler() {};
-       virtual void registerHandler(UwbGdbuslibManager *manager_skeleton) = 0;
-       virtual UwbManager *getManager() = 0;
-};
-
-}
-
-#endif /* __METHOD_HANDLER_H__ */
index 2c3bc3ee7ebb45d2cb850ad8930aeaeeedba01cd..e6b5595f76dedcf73b88e644ef05098d5f5af802 100644 (file)
@@ -29,6 +29,7 @@
 
 #include <stdbool.h>
 #include <list>
+#include <chrono>
 
 #include "MQTTAsync.h"
 #include "UwbMqttRequest.h"
@@ -70,8 +71,8 @@ public:
        int unsubscribe(std::unique_ptr<UwbMqttRequest> request);
        int publish(std::unique_ptr<UwbMqttRequest> request);
 private:
-       static constexpr int _mqtt_connect_timeout = 2;
-       static constexpr int _connection_retry_timeout = 5;
+       static constexpr std::chrono::milliseconds _mqtt_connect_timeout{2000};
+       static constexpr std::chrono::milliseconds _connection_retry_timeout{5000};
        guint _retry_connect_source;
        MQTTAsync _mqtt_client;
        std::function<void(bool)> _connection_state_cb;
index beb0b8312d5e40d67d7a624d76a23f110a47bfe7..8baa2fd5b3543feadaea791fe6e3ab3862b31a31 100644 (file)
@@ -17,6 +17,8 @@
 #ifndef __NODE_H__
 #define __NODE_H__
 
+#include <chrono>
+
 //#include <uwb-log-def.h>
 #include <uwb-hpi.h>
 
@@ -29,34 +31,25 @@ namespace UwbManagerNamespace {
 class Node {
 public:
        Node(): _distance(0), _pan_id(0), _node_id(0), _x(0), _y(0), _z(0),
-       _is_remote(false), _is_calculated(false), _tech(TECH_UNKNOWN), _last_update(0) {};
+       _is_remote(false), _is_calculated(false), _tech(TECH_UNKNOWN),
+       _last_update(std::chrono::steady_clock::now()) {};
 
        Node(int pan_id, unsigned long long node_id, int x, int y, int z) :
                _distance(0), _pan_id(pan_id), _node_id(node_id), _x(x), _y(y), _z(z),
-               _is_remote(false), _is_calculated(false), _tech(TECH_UNKNOWN), _last_update(0) {};
+               _is_remote(false), _is_calculated(false), _tech(TECH_UNKNOWN),
+               _last_update(std::chrono::steady_clock::now()) {};
 
        Node(unsigned long long distance, int pan_id, unsigned long long node_id,
                        int x, int y, int z, bool is_remote, bool is_calculated, int tech) :
                _distance(distance), _pan_id(pan_id), _node_id(node_id),
                _x(x), _y(y), _z(z), _is_remote(is_remote), _is_calculated(is_calculated),
-               _tech(tech), _last_update(0) {};
+               _tech(tech), _last_update(std::chrono::steady_clock::now()) {};
 
        Node(uwb_hpi_node_s *node) :
                _distance(node->distance), _pan_id(node->pan_id), _node_id(node->node_id),
                _x(node->x), _y(node->y), _z(node->z), _is_remote(node->is_remote),
-               _is_calculated(false), _tech(TECH_UWB), _last_update(0){};
-       Node(const Node &node) {
-               _distance = node._distance;
-               _pan_id = node._pan_id;
-               _node_id = node._node_id;
-               _x = node._x;
-               _y = node._y;
-               _z = node._z;
-               _is_remote = node._is_remote;
-               _is_calculated = node._is_calculated;
-               _tech = node._tech;
-               _last_update = node._last_update;
-       }
+               _is_calculated(false), _tech(TECH_UWB),
+               _last_update(std::chrono::steady_clock::now()){};
        Node(const Node *node) {
                _distance = node->_distance;
                _pan_id = node->_pan_id;
@@ -70,7 +63,12 @@ public:
                _last_update = node->_last_update;
        }
 
-       //~Node(){UWB_LOGI("%lld removed", _last_update);}
+       //~Node(){UWB_LOGI("%llu removed", _node_id);}
+       Node(const Node &node) = default;
+       Node& operator=(const Node&) = default;
+       Node(Node&&) = default;
+       Node& operator=(Node&&) = default;
+
        void setDistance(unsigned long long distance) {_distance = distance;};
        unsigned long long getDistance() {return _distance;};
        void setPanId(int id) {_pan_id = id;};
@@ -89,8 +87,8 @@ public:
        void setIsCalculated(bool is_calculated) {_is_calculated = is_calculated;};
        bool getTech(void) {return _tech;};
        void setTech(int tech) {_tech = tech;};
-       uint64_t getLastUpdate(void) {return _last_update;};
-       void setLastUpdate(uint64_t update_time) {_last_update = update_time;};
+       std::chrono::steady_clock::time_point getLastUpdate(void) {return _last_update;};
+       void setLastUpdate(std::chrono::steady_clock::time_point update_time) {_last_update = update_time;};
        bool hasSamePosition(Node *node) {return (_x == node->_x && _y == node->_y && _z == node->_z);};
 private:
        unsigned long long _distance;
@@ -102,7 +100,7 @@ private:
        bool _is_remote;
        bool _is_calculated;
        int _tech;
-       uint64_t _last_update;
+       std::chrono::steady_clock::time_point _last_update;
 };
 
 }
index c7f1ed63605b7d0a49cfd4c6112b8b9e329a6209..4adb235929a59c084b5066042a1fb4d54f131b2c 100644 (file)
@@ -30,8 +30,11 @@ public:
        UwbConfig(std::shared_ptr<UwbRangePlugin> range_plugin) :
                _configurations(nullptr), _range_plugin(range_plugin) {};
 
-       UwbConfig(const UwbConfig& config);
        ~UwbConfig();
+       UwbConfig(const UwbConfig& config);
+       UwbConfig& operator=(const UwbConfig& config);
+       UwbConfig(UwbConfig&& config) = default;
+       UwbConfig& operator=(UwbConfig&& config) = default;
 
        int loadConfiguration(void);
        int setConfigurations(GVariant *configurations);
index d62ae9ad76db7d12f25b6636feb2a87492487be6..3daf230fd93dccbebf76d2db430e155fac21ce2f 100644 (file)
@@ -47,7 +47,6 @@ public:
                _set_position(nullptr),
                _send_message(nullptr),
                _send_message_to(nullptr) {};
-       ~UwbDbusIfaceAdapter();
 
        void setTest(std::function<int (void)> test)
        {_test = test;};
@@ -120,8 +119,7 @@ public:
        void init(GDBusConnection *connection, UwbGdbuslibManager *manager_skeleton);
        void deinit(void);
 private:
-       const std::string _uwb_dbus_path_str =
-                       std::string("/org/tizen/uwb/manager");
+       const std::string _uwb_dbus_path_str{"/org/tizen/uwb/manager"};
        std::function<int (void)> _test;
        std::function<int (void)> _reset;
        std::function<int (void)> _factory_reset;
index 7dbdae608b00995a009b39b8ecf3781894af162f..73c19ec21f6bb05b824c1fc5fd2604bb94705f65 100644 (file)
@@ -31,6 +31,10 @@ class UwbDbusManager {
 public:
        UwbDbusManager() : _owner_id(0), _manager_skeleton(nullptr), _bus_acquired_cb(nullptr) {};
        ~UwbDbusManager();
+       UwbDbusManager(const UwbDbusManager &) = default;
+       UwbDbusManager& operator=(const UwbDbusManager&) = default;
+       UwbDbusManager(UwbDbusManager&&) = default;
+       UwbDbusManager& operator=(UwbDbusManager&&) = default;
 
        void setBusAcquiredCallback(std::function<void(GDBusConnection *, UwbGdbuslibManager *)> bus_acquired_cb)
        {_bus_acquired_cb = bus_acquired_cb;};
@@ -44,8 +48,7 @@ public:
        void emitNodeRemovedSignal(Node *p_node);
        UwbGdbuslibManager *getManagerSkeleton(void) {return _manager_skeleton;};
 private:
-       const std::string uwb_dbus_service_str =
-                       std::string("org.tizen.uwb");
+       const std::string uwb_dbus_service_str{"org.tizen.uwb"};
        guint _owner_id;
 
        /* Add interface to default object path */
index 01e5eacdcb7a8323d9fa61c75b3a6d66bc95ed16..0499bc2535db3208cd2eaa01bbec240b5ab5acc1 100644 (file)
@@ -30,8 +30,8 @@ enum class UwbMqttMessageType {
 class UwbMqttMessage {
 public:
        UwbMqttMessage();
-       ~UwbMqttMessage();
        UwbMqttMessage(Node &node_info);
+
        std::string &getTopic(void);
        std::string &getPayload(void);
 private:
index 80d5ddc639c3ada97b53c12c0f3bb83787bd5c86..d0ebbcd1ddd7fec4666274fe9a0c426b1042782c 100644 (file)
@@ -30,6 +30,7 @@ public:
        UwbMqttRequest(void);
        UwbMqttRequest(int qos, std::unique_ptr<UwbMqttMessage> mqtt_msg);
        UwbMqttRequest(int qos, int retained, std::unique_ptr<UwbMqttMessage> mqtt_msg);
+
        int getQos(void) {return _qos;};
        int getRetained(void) {return _retained;};
        std::string &getTopic(void) {return _mqtt_msg->getTopic();};
index aa8ec8b6276f3a0f350c3a24647fa622995d27a4..e213f63c3a9da5b5104332b5c1dc4e22238339a1 100644 (file)
@@ -29,7 +29,7 @@ public:
                _is_enable(false), _pan_id(0), _range_plugin(nullptr){};
        UwbNetwork(std::shared_ptr<UwbRangePlugin> range_plugin) :
                _is_enable(false), _pan_id(0), _range_plugin(range_plugin){};
-       ~UwbNetwork();
+
        void setPanId(int pan_id) {_pan_id = pan_id;};
        int getPanId(void) {return _pan_id;};
        bool is_enable(void) {return _is_enable;};
index e6a878f14ced21564e7a12283b8241cd60dc85c7..5784cfda7f9da93f48d70b3142ec9e1f71437417 100644 (file)
@@ -29,12 +29,18 @@ namespace UwbManagerNamespace {
 
 class UwbPluginManager {
 public:
+       UwbPluginManager() {};
        ~UwbPluginManager();
+       UwbPluginManager(const UwbPluginManager &) = default;
+       UwbPluginManager& operator=(const UwbPluginManager&) = default;
+       UwbPluginManager(UwbPluginManager&&) = default;
+       UwbPluginManager& operator=(UwbPluginManager&&) = default;
+
        int load(std::shared_ptr<UwbPlugin> plugin);
        int unload(std::shared_ptr<UwbPlugin> plugin);
 private:
        std::map <std::shared_ptr<UwbPlugin>, void *>_plugins;
-       const std::string _func_tbl_symbol = std::string("uwb_plugin_load");
+       const std::string _func_tbl_symbol{"uwb_plugin_load"};
 };
 
 }
index cdd205b2f8ba887903cc8f1eec93ae95fbb1de72..4666d7343b3a406cddfe90d9e1783c48f15b3678 100644 (file)
@@ -29,7 +29,6 @@ class UwbPosition {
 public:
        UwbPosition(std::shared_ptr<UwbRangePlugin> range_plugin) :
                _range_plugin(range_plugin){};
-       ~UwbPosition();
 
        int update(void);
 
index abdf8c956abe1c0b4f7a7bfff87a48fae007471e..fd697d783d51004dc25464bebb7e8b638d2bb30e 100644 (file)
@@ -1,6 +1,6 @@
 Name:       uwb-manager
 Summary:    This is the daemon managing UWB related functionalities
-Version:    0.0.2
+Version:    0.0.3
 Release:    1
 Group:      Network & Connectivity/Wireless
 License:    Apache-2.0
index 583f27a87d6b80b77573637151b85d5156977c50..e9f98abe661d7311a6094b0f3d74421384f79dac 100644 (file)
@@ -16,7 +16,6 @@
 #include <unistd.h>
 #include <sys/types.h>
 #include <algorithm>
-#include <chrono>
 
 #include <uwb-log-def.h>
 
@@ -75,12 +74,6 @@ void LocationManager::unsetNodeRemovedCallback()
        this->_node_removed_cb = nullptr;
 }
 
-static uint64_t __get_current_miliseconds()
-{
-       return std::chrono::duration_cast<std::chrono::milliseconds>\
-                       (std::chrono::high_resolution_clock::now().time_since_epoch()).count();
-}
-
 void LocationManager::extractNodeInfo(char *topic, unsigned char *payload, Node *node)
 {
        std::string node_id_str = std::string(topic).substr(
@@ -113,7 +106,7 @@ void LocationManager::extractNodeInfo(char *topic, unsigned char *payload, Node
        node->setX(x);
        node->setY(y);
        node->setZ(z);
-       node->setLastUpdate(__get_current_miliseconds());
+       node->setLastUpdate(std::chrono::steady_clock::now());
 }
 
 static bool __is_mqtt_message_vaild(char *topic, int topic_len,
@@ -165,10 +158,10 @@ void LocationManager::messageArrived(char *topic, int topic_len,
        bool added = itr == this->_node_map.end();
 
        if (added) {
-               if (this->_node_added_cb != nullptr)
+               if (this->_node_added_cb)
                        this->_node_added_cb(node_info.get());
        } else {
-               if (this->_node_updated_cb != nullptr)
+               if (this->_node_updated_cb)
                        this->_node_updated_cb(node_info.get());
        }
 
@@ -262,7 +255,7 @@ static gboolean __broadcast_position(gpointer user_data)
 int LocationManager::startPublishPosition(void)
 {
        this->_position_broadcast_source =
-                       g_timeout_add(LocationManager::_position_broadcast_interval * 1000,
+                       g_timeout_add(LocationManager::_position_broadcast_interval.count(),
                                        __broadcast_position,
                                        (gpointer)this);
        return 0;
@@ -335,7 +328,7 @@ int LocationManager::connectMqttBroker(const char *server, int port)
 void LocationManager::updateOwnUwbPosition(void)
 {
        this->_current = this->_uwb_position->getOwnNode();
-       if (this->_position_updated_cb != nullptr)
+       if (this->_position_updated_cb)
                this->_position_updated_cb(&(this->_current));
 }
 
@@ -349,15 +342,15 @@ void LocationManager::updateUwbNodes(void)
        auto itr = this->_node_map.find(p_node->getNodeId());
        bool added = itr == this->_node_map.end();
 
-       p_node->setLastUpdate(__get_current_miliseconds());
+       p_node->setLastUpdate(std::chrono::steady_clock::now());
        this->_node_map[p_node->getNodeId()] =
                        std::unique_ptr<Node>((Node *)new Node(p_node));
 
        if (added) {
-               if (this->_node_added_cb != nullptr)
+               if (this->_node_added_cb)
                        this->_node_added_cb(p_node);
        } else {
-               if (this->_node_updated_cb != nullptr)
+               if (this->_node_updated_cb)
                        this->_node_updated_cb(p_node);
        }
     }
@@ -365,17 +358,17 @@ void LocationManager::updateUwbNodes(void)
 
 void LocationManager::removeOutdatedUwbNodes(void)
 {
-       uint64_t current_mil = __get_current_miliseconds();
+       auto current_mil = std::chrono::steady_clock::now();
 
        /* remove node which is not found during
-       *LocationManager::_default_remove_duration * 1000 miliseconds
+       *LocationManager::_default_remove_duration miliseconds
        */
 
        for (auto itr = this->_node_map.begin(); itr != this->_node_map.end();) {
        Node *node_ptr = itr->second.get();
-       if (current_mil - node_ptr->getLastUpdate()
-                        > LocationManager::_default_remove_duration * 1000) {
-               if (this->_node_removed_cb != nullptr)
+       if (std::chrono::duration_cast<std::chrono::milliseconds>(current_mil - node_ptr->getLastUpdate()).count()
+                       > LocationManager::_default_remove_duration.count()) {
+               if (this->_node_removed_cb)
                        this->_node_removed_cb(node_ptr);
                itr = this->_node_map.erase(itr);
        } else
index 35223740b9e39eae20d96a69c320516d175fea44..33262e7308a775b114f29aa5a40dc893dc8450df 100644 (file)
@@ -129,7 +129,7 @@ int MqttContext::createMqttClient(const char *server, int port)
 {
        __UWB_LOG_FUNC_ENTER__;
 
-       retv_if(this->_mqtt_client != nullptr, -1);
+       retv_if(this->_mqtt_client, -1);
 
        UWB_LOGI("Connect to %s:tcp %d", server, port);
 
@@ -157,7 +157,7 @@ int MqttContext::createMqttClient(const char *server, int port)
                        __message_arrived, nullptr);
 
        __UWB_LOG_FUNC_EXIT__;
-       return this->_mqtt_client != nullptr ? 0 : -1;
+       return this->_mqtt_client ? 0 : -1;
 }
 
 int MqttContext::destroyMqttClient(void)
@@ -244,7 +244,7 @@ void MqttContext::enableRetryingConnect(void)
        }
 
        this->_retry_connect_source =
-                       g_timeout_add(MqttContext::_connection_retry_timeout * 1000,
+                       g_timeout_add(MqttContext::_connection_retry_timeout.count(),
                                        __retry_connect,
                                        (gpointer)this);
 }
@@ -280,7 +280,7 @@ int MqttContext::connectBroker(void)
 
        opts.keepAliveInterval = 20;
 
-       opts.connectTimeout = this->_mqtt_connect_timeout;
+       opts.connectTimeout = this->_mqtt_connect_timeout.count();
        opts.cleansession = 1;
        opts.onSuccess = __connect_on_success_cb;
        opts.onFailure = __connect_on_failure_cb;
index 7319821d2a1933f376e3abd809f25c4c99f4cedf..ecb03bdfc0878069aebb370adca3076bdac8657c 100755 (executable)
@@ -26,12 +26,6 @@ using namespace UwbManagerNamespace;
 
 #define CONFIGFILE     tzplatform_mkpath(TZ_SYS_RO_ETC, "/uwb/uwb-plugin.conf")
 
-
-UwbConfig::UwbConfig(const UwbConfig& config)
-{
-       this->_configurations = g_variant_ref(config._configurations);
-}
-
 UwbConfig::~UwbConfig()
 {
        __UWB_LOG_FUNC_ENTER__;
@@ -42,6 +36,20 @@ UwbConfig::~UwbConfig()
        __UWB_LOG_FUNC_EXIT__;
 }
 
+UwbConfig::UwbConfig(const UwbConfig& config)
+{
+       this->_range_plugin = config._range_plugin;
+       this->_configurations = g_variant_ref(config._configurations);
+}
+
+UwbConfig& UwbConfig::operator=(const UwbConfig& config)
+{
+       this->_range_plugin = config._range_plugin;
+       this->_configurations = g_variant_ref(config._configurations);
+
+       return *this;
+}
+
 int UwbConfig::loadConfiguration(void)
 {
        JsonParser *parser = NULL;
@@ -80,7 +88,7 @@ int UwbConfig::loadConfiguration(void)
                g_variant_unref(this->_configurations);
        this->_configurations = configuration;
 
-       if (this->_range_plugin != nullptr)
+       if (this->_range_plugin)
                this->_range_plugin->setConfigurations(0, configuration);
 
        g_object_unref(parser);
index f5a6fa5c1784f58811ec105bab27e83b1abf217a..984afbb690b08825bc3256abb7607891af0afaf4 100644 (file)
@@ -47,10 +47,6 @@ using namespace UwbManagerNamespace;
                g_free(parameters_debug_str);\
        } while (0)
 
-UwbDbusIfaceAdapter::~UwbDbusIfaceAdapter()
-{
-}
-
 static void __dbus_return_err(uwb_error_e ret, GDBusMethodInvocation *invocation)
 {
        GdbusError gdbus_error;
@@ -532,8 +528,7 @@ static struct {
                {"handle-set-position", (void *)__handle_set_position},
 
                {"handle-send-message", (void *)__handle_send_message},
-               {"handle-send-message-to", (void *)__handle_send_message_to},
-               {NULL, NULL}
+               {"handle-send-message-to", (void *)__handle_send_message_to}
 };
 
 void UwbDbusIfaceAdapter::init(GDBusConnection *connection,
@@ -542,11 +537,11 @@ void UwbDbusIfaceAdapter::init(GDBusConnection *connection,
        __UWB_LOG_FUNC_ENTER__;
 
        /* Register method callbacks as signal callback */
-       for (int i = 0; handlers[i].method_name != NULL; ++i)
+       for (const auto &handler : handlers)
                g_signal_connect(
                                manager_skeleton,
-                               handlers[i].method_name,
-                               G_CALLBACK(handlers[i].handler),
+                               handler.method_name,
+                               G_CALLBACK(handler.handler),
                                gpointer(this));
 
        /* Set connection to 'manager' */
index e9a0a66bc0188d4ff7d2c9add29d329632215fb9..29f8dc1486559f289a9d144adbe090dc2671523a 100644 (file)
 
 using namespace UwbManagerNamespace;
 
-UwbMqttMessage::~UwbMqttMessage()
-{
-       __UWB_LOG_FUNC_ENTER__;
-
-       __UWB_LOG_FUNC_EXIT__;
-}
-
 UwbMqttMessage::UwbMqttMessage()
 {
        this->_topic = this->_broadcast_position_topic_prefix + std::string("+");
index 1f9d6452aebc02fd7045f3867f4ba7d0d42883c8..53379e11afa89cbdd542a3c79844f28881e20a2c 100644 (file)
 
 using namespace UwbManagerNamespace;
 
-UwbNetwork::~UwbNetwork()
-{
-       __UWB_LOG_FUNC_ENTER__;
-
-       __UWB_LOG_FUNC_EXIT__;
-       return;
-}
-
 static void __destroy_node(gpointer data)
 {
        if (data != NULL) {
index 255b39a441dab5d29cd87473d23652b78705a5ce..443aeda18c33e4777f8bfb2a8345820b74883272 100644 (file)
 
 using namespace UwbManagerNamespace;
 
-UwbPosition::~UwbPosition()
-{
-       __UWB_LOG_FUNC_ENTER__;
-
-       _node_list.clear();
-
-       __UWB_LOG_FUNC_EXIT__;
-       return;
-}
-
 int UwbPosition::updateUwbOwnNode()
 {
        if (this->_range_plugin == nullptr)
index 77e4c33c5915723ec1a420a5de94de774c445c45..e36938ec1da6b3fe5b30c7c1e8af26e2a4ae3788 100644 (file)
@@ -60,7 +60,7 @@ static std::atomic<GMainLoop *>main_loop(nullptr);
 
 static void __run_main_loop(void)
 {
-       if (main_loop != nullptr)
+       if (main_loop)
                return;
 
        main_loop = g_main_loop_new(nullptr, FALSE);