Avoid enum as function argument for headerConvert()

- While this /nearly/ qualifies for enum, places like python
  argument converting will not be able to produce "true enum" values.
  So dont even try.

diff --git a/lib/header.h b/lib/header.h
index dab5070..b39f57a 100644 (file)
--- a/lib/header.h
+++ b/lib/header.h
@@ -434,10 +434,10 @@ typedef enum headerConvOps_e {
 /** \ingroup header
  * Convert header to/from (legacy) data presentation
  * @param h            header
- * @param op           operation
+ * @param op           one of headerConvOps operations
  * @return             1 on success, 0 on failure
  */
-int headerConvert(Header h, headerConvOps op);
+int headerConvert(Header h, int op);
 
 #ifdef __cplusplus
 }

diff --git a/lib/legacy.c b/lib/legacy.c
index 9765d27..df7911e 100644 (file)
--- a/lib/legacy.c
+++ b/lib/legacy.c
@@ -207,7 +207,7 @@ static void legacyRetrofit(Header h)
     }
 }
 
-int headerConvert(Header h, headerConvOps op)
+int headerConvert(Header h, int op)
 {
     int rc = 1;
 

diff --git a/python/header-py.c b/python/header-py.c
index c83b1a2..b6e21cc 100644 (file)
--- a/python/header-py.c
+++ b/python/header-py.c
@@ -257,7 +257,7 @@ static int hdrContains(hdrObject *s, PyObject *pytag)
 static PyObject *hdrConvert(hdrObject *self, PyObject *args, PyObject *kwds)
 {
     char *kwlist[] = {"op", NULL};
-    headerConvOps op = -1;
+    int op = -1;
 
     if (!PyArg_ParseTupleAndKeywords(args, kwds, "i", kwlist, &op)) {
         return NULL;