staging: comedi: tests: Simplify conditional evaluation
authorDeepak R Varma <mh12gx2825@gmail.com>
Mon, 19 Oct 2020 17:14:26 +0000 (22:44 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 26 Oct 2020 05:53:10 +0000 (06:53 +0100)
Boolean comparison of the condition inside unittest function is
unnecessary and can be simplified by directly using the condition
outcome for evaluation. Issue reported by :
scripts/coccinelle/misc/boolinit.cocci

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Link: https://lore.kernel.org/r/20201019171426.GA72818@ubuntu204
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/tests/ni_routes_test.c

index eaefaf5..4061b3b 100644 (file)
@@ -499,13 +499,13 @@ void test_route_register_is_valid(void)
        const struct ni_route_tables *T = &private.routing_tables;
 
        init_pci_fake();
-       unittest(route_register_is_valid(4, O(4), T) == false,
+       unittest(!route_register_is_valid(4, O(4), T),
                 "check for bad source 4-->4\n");
-       unittest(route_register_is_valid(0, O(1), T) == true,
+       unittest(route_register_is_valid(0, O(1), T),
                 "find first source\n");
-       unittest(route_register_is_valid(4, O(6), T) == true,
+       unittest(route_register_is_valid(4, O(6), T),
                 "find middle source\n");
-       unittest(route_register_is_valid(9, O(8), T) == true,
+       unittest(route_register_is_valid(9, O(8), T),
                 "find last source");
 }