server: Fix fake "Address already in use" error
authorLiu Wenlong <liuwl.fnst@cn.fujitsu.com>
Mon, 26 Aug 2019 09:08:22 +0000 (17:08 +0800)
committerLiu Wenlong <liuwl.fnst@cn.fujitsu.com>
Mon, 26 Aug 2019 17:32:45 +0000 (01:32 +0800)
In the current workflow, socket file will be deleted if it already exists.
However, if the socket file is a symbolic link and the file that it refers
to doesn't exist, we will got "Address already in use" because bind()
thinks the socket file exists and won't create it.

Now, use lstat() to determine whether the socket file exists.

Signed-off-by: Liu Wenlong <liuwl.fnst@cn.fujitsu.com>
src/wayland-server.c

index 83b984f..3bc6ed7 100644 (file)
@@ -1393,7 +1393,7 @@ wl_socket_lock(struct wl_socket *socket)
                goto err_fd;
        }
 
-       if (stat(socket->addr.sun_path, &socket_stat) < 0 ) {
+       if (lstat(socket->addr.sun_path, &socket_stat) < 0 ) {
                if (errno != ENOENT) {
                        wl_log("did not manage to stat file %s\n",
                                socket->addr.sun_path);