zink: use = and not |= for VkMemoryPropertyFlags during resource creation
authorMike Blumenkrantz <michael.blumenkrantz@gmail.com>
Thu, 13 Aug 2020 14:23:24 +0000 (10:23 -0400)
committerMarge Bot <eric+marge@anholt.net>
Wed, 10 Feb 2021 13:28:10 +0000 (13:28 +0000)
the previous value of this isn't used, so be explicit here

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8942>

src/gallium/drivers/zink/zink_resource.c

index 50c597753597f96d3a0b7307c06253608520c9c8..94a8beb0efaaf3ab964a3791fb184af4fd2f096a 100644 (file)
@@ -109,7 +109,7 @@ resource_create(struct pipe_screen *pscreen,
    res->base.screen = pscreen;
 
    VkMemoryRequirements reqs = {};
-   VkMemoryPropertyFlags flags = 0;
+   VkMemoryPropertyFlags flags;
 
    res->internal_format = templ->format;
    if (templ->target == PIPE_BUFFER) {
@@ -166,7 +166,7 @@ resource_create(struct pipe_screen *pscreen,
       }
 
       vkGetBufferMemoryRequirements(screen->dev, res->buffer, &reqs);
-      flags |= VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT;
+      flags = VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT;
    } else {
       res->format = zink_get_format(screen, templ->format);
 
@@ -285,9 +285,9 @@ resource_create(struct pipe_screen *pscreen,
 
       vkGetImageMemoryRequirements(screen->dev, res->image, &reqs);
       if (templ->usage == PIPE_USAGE_STAGING || (screen->winsys && (templ->bind & (PIPE_BIND_SCANOUT|PIPE_BIND_DISPLAY_TARGET|PIPE_BIND_SHARED))))
-        flags |= VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT;
+        flags = VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT;
       else
-        flags |= VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT;
+        flags = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT;
    }
 
    VkMemoryAllocateInfo mai = {};