remote-server: fix svace issues

98760 UNINIT.LOCAL_VAR.EX
98761 UNINIT.LOCAL_VAR.EX
84719 UNREACHABLE_CODE

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: Ib9c3e69279ff3ab2a79fee8f9bde368c62cc5c67

diff --git a/PinCodeService/Util/RemoteLogger.cpp b/PinCodeService/Util/RemoteLogger.cpp
index bafecb879fb05e3d8130ead6eb9d6605eb853b37..628814c2c7da3725515e293bb988cbc027f432c3 100755 (executable)
--- a/PinCodeService/Util/RemoteLogger.cpp
+++ b/PinCodeService/Util/RemoteLogger.cpp
@@ -175,18 +175,8 @@ bool CRemoteLogger::m_Create(void)
 
 bool CRemoteLogger::m_GetFWVersion(void)
 {
-       char *strBuildVer = NULL;
-
-       if (strBuildVer != NULL) {
-               m_strFWVersion.assign(strBuildVer);
-               free(strBuildVer);
-               strBuildVer = NULL;
-       } else {
-               if (strBuildVer == NULL) {
-                       REMOTE_PRINT_DEBUG("ERR: no build version");
-                       return false;
-               }
-       }
-       return true;
+       // TODO:
+       REMOTE_PRINT_DEBUG("ERR: no build version");
+       return false;
 }
 

diff --git a/Src/Common/REMOTEApp.cpp b/Src/Common/REMOTEApp.cpp
index bd6d08a988643c0aacd2f5508324ce20e4a79a65..4a62644ae0de4e03eb289d014aadb3ad5ad73162 100755 (executable)
--- a/Src/Common/REMOTEApp.cpp
+++ b/Src/Common/REMOTEApp.cpp
@@ -48,7 +48,7 @@ int REMOTE::App::launch_app(const char *appid)
 
        PRINT_INFO("[FUNC] rep_launch_app");
 
-       int ret;
+       int ret = -1;
 
        bundle *pBundle = bundle_create();
 
@@ -60,7 +60,7 @@ int REMOTE::App::launch_app(const char *appid)
        }
 
        if (aul_app_is_running_for_uid(appid, tzplatform_getuid(TZ_SYS_DEFAULT_USER)))
-               aul_resume_app_for_uid(appid, tzplatform_getuid(TZ_SYS_DEFAULT_USER));
+               ret = aul_resume_app_for_uid(appid, tzplatform_getuid(TZ_SYS_DEFAULT_USER));
        else
                ret = aul_launch_app_for_uid(appid, pBundle, tzplatform_getuid(TZ_SYS_DEFAULT_USER));
 
@@ -88,7 +88,7 @@ int REMOTE::App::launch_browser(const char *url)
 
        PRINT_INFO("[FUNC] rep_launch_browser");
 
-       int ret;
+       int ret = -1;
 
        bundle *pBundle = bundle_create();
 
@@ -102,7 +102,7 @@ int REMOTE::App::launch_browser(const char *url)
        aul_svc_set_uri(pBundle, url); // url setting API
 
        if (aul_app_is_running_for_uid("org.tizen.browser", tzplatform_getuid(TZ_SYS_DEFAULT_USER)))
-               aul_resume_app_for_uid("org.tizen.browser", tzplatform_getuid(TZ_SYS_DEFAULT_USER));
+               ret = aul_resume_app_for_uid("org.tizen.browser", tzplatform_getuid(TZ_SYS_DEFAULT_USER));
        else
                ret = aul_launch_app_for_uid("org.tizen.browser", pBundle, tzplatform_getuid(TZ_SYS_DEFAULT_USER));