vt_ioctl: Remove in_interrupt() check
authorAhmed S. Darwish <a.darwish@linutronix.de>
Mon, 8 Feb 2021 18:16:14 +0000 (19:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Feb 2021 10:45:04 +0000 (11:45 +0100)
reset_vc() uses a "!in_interrupt()" conditional before resetting the
palettes, which is a blocking operation. Since commit
   8b6312f4dcc1e ("[PATCH] vt: refactor console SAK processing")

all calls are invoked from a workqueue process context, with the
blocking console lock always acquired.

Remove the "!in_interrupt()" check.

Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/r/20210208181615.381861-2-bigeasy@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vt/vt_ioctl.c

index 4a4cbd4..89aeaf3 100644 (file)
@@ -930,8 +930,7 @@ void reset_vc(struct vc_data *vc)
        put_pid(vc->vt_pid);
        vc->vt_pid = NULL;
        vc->vt_newvt = -1;
-       if (!in_interrupt())    /* Via keyboard.c:SAK() - akpm */
-               reset_palette(vc);
+       reset_palette(vc);
 }
 
 void vc_SAK(struct work_struct *work)