Also upload product name, company name and version in crash report.

diff --git a/common/api/lib/crash-reporter.coffee b/common/api/lib/crash-reporter.coffee
index 3dd8821..89d48f2 100644 (file)
--- a/common/api/lib/crash-reporter.coffee
+++ b/common/api/lib/crash-reporter.coffee
@@ -12,6 +12,14 @@ class CrashReporter
     ignoreSystemCrashHandler ?= false
     extra ?= {}
 
+    extra._productName ?= productName
+    extra._companyName ?= companyName
+    extra._version ?=
+      if process.__atom_type is 'browser'
+        require('app').getVersion()
+      else
+        require('remote').require('app').getVersion()
+
     start = -> binding.start productName, companyName, submitUrl, autoSubmit, ignoreSystemCrashHandler, extra
 
     if process.platform is 'darwin'

diff --git a/spec/api/crash-reporter.coffee b/spec/api/crash-reporter.coffee
index ec66402..fc4e91d 100644 (file)
--- a/spec/api/crash-reporter.coffee
+++ b/spec/api/crash-reporter.coffee
@@ -19,6 +19,9 @@ describe 'crash-reporter module', ->
         assert.equal fields['platform'], process.platform
         assert.equal fields['extra1'], 'extra1'
         assert.equal fields['extra2'], 'extra2'
+        assert.equal fields['_productName'], 'Zombies'
+        assert.equal fields['_companyName'], 'Umbrella Corporation'
+        assert.equal fields['_version'], require('remote').require('app').getVersion()
         assert files['upload_file_minidump']['name']?
 
         w.destroy()

diff --git a/spec/fixtures/api/crash.html b/spec/fixtures/api/crash.html
index b0c3664..cb6c435 100644 (file)
--- a/spec/fixtures/api/crash.html
+++ b/spec/fixtures/api/crash.html
@@ -3,7 +3,8 @@
 <script type="text/javascript" charset="utf-8">
 var crashReporter = require('crash-reporter');
 crashReporter.start({
-  productName: 'Something other than Atom-Shell',
+  productName: 'Zombies',
+  companyName: 'Umbrella Corporation',
   submitUrl: 'http://127.0.0.1:1127',
   autoSubmit: true,
   ignoreSystemCrashHandler: true,