projects
/
platform
/
upstream
/
glib.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b2d848e
)
GDBusActionGroup: hold ref until async init done
author
Pavel Vasin
<rat4vier@gmail.com>
Mon, 16 Jul 2012 11:57:26 +0000
(15:57 +0400)
committer
Matthias Clasen
<mclasen@redhat.com>
Mon, 6 Aug 2012 14:08:13 +0000
(10:08 -0400)
to avoid use-after-free if GDBusActionGroup was finalized
https://bugzilla.gnome.org/show_bug.cgi?id=679509
gio/gdbusactiongroup.c
patch
|
blob
|
history
diff --git
a/gio/gdbusactiongroup.c
b/gio/gdbusactiongroup.c
index
6c55454
..
b1c7649
100644
(file)
--- a/
gio/gdbusactiongroup.c
+++ b/
gio/gdbusactiongroup.c
@@
-268,6
+268,8
@@
g_dbus_action_group_describe_all_done (GObject *source,
g_variant_iter_free (iter);
g_variant_unref (reply);
}
+
+ g_object_unref (group);
}
@@
-283,7
+285,7
@@
g_dbus_action_group_async_init (GDBusActionGroup *group)
g_dbus_connection_call (group->connection, group->bus_name, group->object_path, "org.gtk.Actions", "DescribeAll", NULL,
G_VARIANT_TYPE ("(a{s(bgav)})"), G_DBUS_CALL_FLAGS_NONE, -1, NULL,
- g_dbus_action_group_describe_all_done, g
roup
);
+ g_dbus_action_group_describe_all_done, g
_object_ref (group)
);
}
static gchar **