Revert "[NUI] Add OverScrolled in WebView"
authorJaehyun Cho <jae_hyun.cho@samsung.com>
Mon, 7 Apr 2025 03:48:44 +0000 (12:48 +0900)
committerJaehyun Cho <jaehyun0cho@gmail.com>
Mon, 7 Apr 2025 03:57:04 +0000 (12:57 +0900)
This reverts commit f9044a6e2a3bd4e9998f03e66e5e498e6b1d6ddd.

src/Tizen.NUI/src/internal/Interop/Interop.WebView.cs
src/Tizen.NUI/src/internal/WebView/WebViewOverScrolledEventArgs.cs [deleted file]
src/Tizen.NUI/src/public/WebView/WebView.cs

index a8d4c15f5efd129fabefdbf004231b0e6f48abda..a13b711597f8c8942317a456e0c83b33b4d94fff 100755 (executable)
@@ -280,9 +280,6 @@ namespace Tizen.NUI
             [global::System.Runtime.InteropServices.DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_WebView_RegisterScrollEdgeReachedCallback")]
             public static extern void RegisterScrollEdgeReachedCallback(global::System.Runtime.InteropServices.HandleRef jarg1, global::System.Runtime.InteropServices.HandleRef jarg2);
 
-            [global::System.Runtime.InteropServices.DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_WebView_RegisterOverScrolledCallback")]
-            public static extern void RegisterOverScrolledCallback(global::System.Runtime.InteropServices.HandleRef jarg1, global::System.Runtime.InteropServices.HandleRef jarg2);
-
             [global::System.Runtime.InteropServices.DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_WebView_RegisterUrlChangedCallback")]
             public static extern void RegisterUrlChangedCallback(global::System.Runtime.InteropServices.HandleRef jarg1, global::System.Runtime.InteropServices.HandleRef jarg2);
 
diff --git a/src/Tizen.NUI/src/internal/WebView/WebViewOverScrolledEventArgs.cs b/src/Tizen.NUI/src/internal/WebView/WebViewOverScrolledEventArgs.cs
deleted file mode 100755 (executable)
index 68cf045..0000000
+++ /dev/null
@@ -1,59 +0,0 @@
-/*
- * Copyright (c) 2025 Samsung Electronics Co., Ltd.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-
-using System;
-using System.ComponentModel;
-
-namespace Tizen.NUI
-{
-    /// <summary>
-    /// Event arguments that passed via the WebView.OverScrolled.
-    /// </summary>
-    [EditorBrowsable(EditorBrowsableState.Never)]
-    public class WebViewOverScrolledEventArgs : EventArgs
-    {
-        internal WebViewOverScrolledEventArgs(Over e)
-        {
-            OverScrolled = e;
-        }
-
-        /// <summary>
-        /// The enumeration for over scrolled.
-        /// </summary>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        public enum Over
-        {
-            [EditorBrowsable(EditorBrowsableState.Never)]
-            Left,
-
-            [EditorBrowsable(EditorBrowsableState.Never)]
-            Right,
-
-            [EditorBrowsable(EditorBrowsableState.Never)]
-            Top,
-
-            [EditorBrowsable(EditorBrowsableState.Never)]
-            Bottom,
-        }
-
-        /// <summary>
-        /// The over scolled direction, e.g. left, right, etc.
-        /// </summary>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        public Over OverScrolled { get; }
-    }
-}
index d7d45e53963c655b632aa08a70c401743f319c7c..c5a979ad2ce36c98133bfc10f1a2b5441c81100c 100755 (executable)
@@ -49,9 +49,6 @@ namespace Tizen.NUI.BaseComponents
         private EventHandler<WebViewScrollEdgeReachedEventArgs> scrollEdgeReachedEventHandler;
         private WebViewScrollEdgeReachedCallback scrollEdgeReachedCallback;
 
-        private EventHandler<WebViewOverScrolledEventArgs> overScrolledEventHandler;
-        private WebViewOverScrolledCallback overScrolledCallback;
-
         private EventHandler<WebViewUrlChangedEventArgs> urlChangedEventHandler;
         private WebViewUrlChangedCallback urlChangedCallback;
 
@@ -266,9 +263,6 @@ namespace Tizen.NUI.BaseComponents
         [UnmanagedFunctionPointer(CallingConvention.StdCall)]
         private delegate void WebViewScrollEdgeReachedCallback(int edge);
 
-        [UnmanagedFunctionPointer(CallingConvention.StdCall)]
-        private delegate void WebViewOverScrolledCallback(int overscrolled);
-
         [UnmanagedFunctionPointer(CallingConvention.StdCall)]
         private delegate void WebViewUrlChangedCallback(string pageUrl);
 
@@ -460,34 +454,6 @@ namespace Tizen.NUI.BaseComponents
             }
         }
 
-        /// <summary>
-        /// Event for the OverScrolled signal which can be used to subscribe or unsubscribe the event handler.<br />
-        /// This signal is emitted when web view is over scrolled.<br />
-        /// </summary>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        public event EventHandler<WebViewOverScrolledEventArgs> OverScrolled
-        {
-            add
-            {
-                if (overScrolledEventHandler == null)
-                {
-                    overScrolledCallback = OnOverScrolled;
-                    IntPtr ip = Marshal.GetFunctionPointerForDelegate(overScrolledCallback);
-                    Interop.WebView.RegisterOverScrolledCallback(SwigCPtr, new HandleRef(this, ip));
-                }
-                overScrolledEventHandler += value;
-            }
-            remove
-            {
-                overScrolledEventHandler -= value;
-                if (overScrolledEventHandler == null)
-                {
-                    IntPtr ip = IntPtr.Zero;
-                    Interop.WebView.RegisterOverScrolledCallback(SwigCPtr, new HandleRef(this, ip));
-                }
-            }
-        }
-
         /// <summary>
         /// Event for the UrlChanged signal which can be used to subscribe or unsubscribe the event handler.<br />
         /// This signal is emitted when url is changed.<br />
@@ -2550,11 +2516,6 @@ namespace Tizen.NUI.BaseComponents
             scrollEdgeReachedEventHandler?.Invoke(this, new WebViewScrollEdgeReachedEventArgs((WebViewScrollEdgeReachedEventArgs.Edge)edge));
         }
 
-        private void OnOverScrolled(int over)
-        {
-            overScrolledEventHandler?.Invoke(this, new WebViewOverScrolledEventArgs((WebViewOverScrolledEventArgs.Over)over));
-        }
-
         private void OnUrlChanged(string pageUrl)
         {
             urlChangedEventHandler?.Invoke(this, new WebViewUrlChangedEventArgs(pageUrl));