Added a gcov flag to gauge line & function coverage. 60/185360/3 accepted/tizen/unified/20180827.160620 submit/tizen/20180827.065334
authorsaerome.kim <saerome.kim@samsung.com>
Mon, 30 Jul 2018 02:09:44 +0000 (11:09 +0900)
committersaerome.kim <saerome.kim@samsung.com>
Mon, 30 Jul 2018 06:48:52 +0000 (15:48 +0900)
- Increased line coverage as well

Change-Id: I9c526aaaecf42216ba179339fbb5540b57b54463
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
CMakeLists.txt
packaging/capi-network-mtp.spec
src/mtp_db.c

index e6b112e..b1d4acd 100755 (executable)
@@ -41,7 +41,11 @@ FOREACH(flag ${${fw_name}_CFLAGS})
     SET(EXTRA_CFLAGS "${EXTRA_CFLAGS} ${flag}")
 ENDFOREACH(flag)
 
-SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS} -fPIC -Wall -Werror")
+IF(BUILD_GCOV)
+       SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS} -fPIC -Wall -Werror -fprofile-arcs -ftest-coverage")
+ELSE(BUILD_GCOV)
+       SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS} -fPIC -Wall -Werror")
+ENDIF(BUILD_GCOV)
 SET(CMAKE_C_FLAGS_DEBUG "-O0 -g")
 
 ADD_DEFINITIONS("-DPREFIX=\"${CMAKE_INSTALL_PREFIX}\"")
index a395812..367fc78 100755 (executable)
@@ -33,12 +33,18 @@ Requires: %{name} = %{version}-%{release}
 %setup -q
 
 %build
+
+%if 0%{?gcov:1}
+export LDFLAGS+=" -lgcov"
+%endif
+
 MAJORVER=`echo %{version} | awk 'BEGIN {FS="."}{print $1}'`
 
 cmake . -DCMAKE_INSTALL_PREFIX=%{_prefix} \
        -DLIB_INSTALL_DIR=%{_libdir} \
        -DFULLVER=%{version} \
-       -DMAJORVER=${MAJORVER}
+       -DMAJORVER=${MAJORVER}\
+       -DBUILD_GCOV=%{?gcov:1}%{!?gcov:0}
 
 make %{?jobs:-j%jobs}
 
@@ -61,4 +67,4 @@ rm -rf %{buildroot}
 %{_includedir}/*.h
 %{_libdir}/pkgconfig/*.pc
 %{_libdir}/libcapi-network-mtp.so
-%{_bindir}/mtp_unit_test
\ No newline at end of file
+%{_bindir}/mtp_unit_test
index 887acdd..1b0923c 100755 (executable)
@@ -29,6 +29,7 @@
 static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
 static sqlite3 *db;
 
+/* LCOV_EXCL_START */
 mtp_error_e mtp_db_init()
 {
        int ret = MTP_ERROR_NONE;
@@ -49,7 +50,6 @@ mtp_error_e mtp_db_init()
        return ret;
 }
 
-/* LCOV_EXCL_START */
 mtp_error_e mtp_db_get_object_info(int mtp_device, int object_handle, mtp_object_info** object_info)
 {
        int ret = MTP_ERROR_NONE;
@@ -117,7 +117,6 @@ mtp_error_e mtp_db_get_object_info(int mtp_device, int object_handle, mtp_object
 
        return ret;
 }
-/* LCOV_EXCL_STOP */
 
 mtp_error_e mtp_db_deinit()
 {
@@ -130,7 +129,7 @@ mtp_error_e mtp_db_deinit()
                sql_ret = sqlite3_close(db);
 
                if (sql_ret != SQLITE_OK)
-                       ret = MTP_ERROR_DB; /* LCOV_EXCL_LINE */
+                       ret = MTP_ERROR_DB;
 
                db = NULL;
        }
@@ -139,3 +138,4 @@ mtp_error_e mtp_db_deinit()
 
        return ret;
 }
+/* LCOV_EXCL_STOP */
\ No newline at end of file