Close unused inherited file descriptor
authorChengwei Yang <chengwei.yang@intel.com>
Tue, 15 Oct 2013 05:23:09 +0000 (13:23 +0800)
committerSimon McVittie <simon.mcvittie@collabora.co.uk>
Fri, 1 Nov 2013 12:54:06 +0000 (12:54 +0000)
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68559
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
dbus/dbus-spawn.c

index af624e7..d1478f0 100644 (file)
@@ -1339,6 +1339,7 @@ _dbus_spawn_async_with_babysitter (DBusBabysitter          **sitter_p,
            */
           signal (SIGPIPE, SIG_IGN);
 
+          close_and_invalidate (&babysitter_pipe[1]);
 #ifdef HAVE_SYSTEMD
          /* log to systemd journal if possible */
          if (fd_out >= 0)
@@ -1356,6 +1357,7 @@ _dbus_spawn_async_with_babysitter (DBusBabysitter          **sitter_p,
        }
       else
        {
+          close_and_invalidate (&child_err_report_pipe[WRITE_END]);
 #ifdef HAVE_SYSTEMD
           close_and_invalidate (&fd_out);
           close_and_invalidate (&fd_err);