Input: keyboard - drop unnecessary calls to input_set_drvdata

If there is no call to dev_get_drvdata() or input_get_drvdata(),
the call to input_set_drvdata() is unnecessary and can be dropped.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

diff --git a/drivers/input/keyboard/adp5520-keys.c b/drivers/input/keyboard/adp5520-keys.c
index db1004d..f0b9b37 100644 (file)
--- a/drivers/input/keyboard/adp5520-keys.c
+++ b/drivers/input/keyboard/adp5520-keys.c
@@ -107,8 +107,6 @@ static int adp5520_keys_probe(struct platform_device *pdev)
        input->phys = "adp5520-keys/input0";
        input->dev.parent = &pdev->dev;
 
-       input_set_drvdata(input, dev);
-
        input->id.bustype = BUS_I2C;
        input->id.vendor = 0x0001;
        input->id.product = 0x5520;

diff --git a/drivers/input/keyboard/bf54x-keys.c b/drivers/input/keyboard/bf54x-keys.c
index 81b07dd..39bcbc3 100644 (file)
--- a/drivers/input/keyboard/bf54x-keys.c
+++ b/drivers/input/keyboard/bf54x-keys.c
@@ -268,8 +268,6 @@ static int bfin_kpad_probe(struct platform_device *pdev)
        input->phys = "bf54x-keys/input0";
        input->dev.parent = &pdev->dev;
 
-       input_set_drvdata(input, bf54x_kpad);
-
        input->id.bustype = BUS_HOST;
        input->id.vendor = 0x0001;
        input->id.product = 0x0001;

diff --git a/drivers/input/keyboard/maple_keyb.c b/drivers/input/keyboard/maple_keyb.c
index 5aa2361..78e3567 100644 (file)
--- a/drivers/input/keyboard/maple_keyb.c
+++ b/drivers/input/keyboard/maple_keyb.c
@@ -196,7 +196,6 @@ static int probe_maple_kbd(struct device *dev)
        __clear_bit(KEY_RESERVED, idev->keybit);
 
        input_set_capability(idev, EV_MSC, MSC_SCAN);
-       input_set_drvdata(idev, kbd);
 
        error = input_register_device(idev);
        if (error)

diff --git a/drivers/input/keyboard/opencores-kbd.c b/drivers/input/keyboard/opencores-kbd.c
index 98ea619..d62b406 100644 (file)
--- a/drivers/input/keyboard/opencores-kbd.c
+++ b/drivers/input/keyboard/opencores-kbd.c
@@ -75,8 +75,6 @@ static int opencores_kbd_probe(struct platform_device *pdev)
        input->name = pdev->name;
        input->phys = "opencores-kbd/input0";
 
-       input_set_drvdata(input, opencores_kbd);
-
        input->id.bustype = BUS_HOST;
        input->id.vendor = 0x0001;
        input->id.product = 0x0001;

diff --git a/drivers/input/keyboard/tca8418_keypad.c b/drivers/input/keyboard/tca8418_keypad.c
index 11d5c76..9f6308f 100644 (file)
--- a/drivers/input/keyboard/tca8418_keypad.c
+++ b/drivers/input/keyboard/tca8418_keypad.c
@@ -358,8 +358,6 @@ static int tca8418_keypad_probe(struct i2c_client *client,
                __set_bit(EV_REP, input->evbit);
        input_set_capability(input, EV_MSC, MSC_SCAN);
 
-       input_set_drvdata(input, keypad_data);
-
        irq = client->irq;
        if (irq_is_gpio)
                irq = gpio_to_irq(irq);

diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c
index 916e2f3..485900f 100644 (file)
--- a/drivers/input/keyboard/tm2-touchkey.c
+++ b/drivers/input/keyboard/tm2-touchkey.c
@@ -193,8 +193,6 @@ static int tm2_touchkey_probe(struct i2c_client *client,
        input_set_capability(touchkey->input_dev, EV_KEY, KEY_PHONE);
        input_set_capability(touchkey->input_dev, EV_KEY, KEY_BACK);
 
-       input_set_drvdata(touchkey->input_dev, touchkey);
-
        error = input_register_device(touchkey->input_dev);
        if (error) {
                dev_err(&client->dev,