aggregator: keep chain functions as dumb as possible.
authorMathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Mon, 26 Jan 2015 12:11:05 +0000 (13:11 +0100)
committerTim-Philipp Müller <tim@centricular.com>
Sat, 2 Dec 2017 15:10:26 +0000 (15:10 +0000)
+ A pad chain function has no business checking other pads,
  that's what the aggregate thread is for.

https://bugzilla.gnome.org/show_bug.cgi?id=742684

libs/gst/base/gstaggregator.c

index d63ce22..28bbdeb 100644 (file)
@@ -1807,8 +1807,7 @@ gst_aggregator_pad_chain (GstPad * pad, GstObject * object, GstBuffer * buffer)
   PAD_UNLOCK (aggpad);
   PAD_STREAM_UNLOCK (aggpad);
 
-  if (gst_aggregator_check_pads_ready (self))
-    SRC_STREAM_BROADCAST (self);
+  SRC_STREAM_BROADCAST (self);
   SRC_STREAM_UNLOCK (self);
 
   GST_DEBUG_OBJECT (aggpad, "Done chaining");