remove unused variables and assignments

and silences some compiler warnings.
I do not understand the code in toke.c but the change aligns the code
with other uses of FUN0OP, it has no warnings and does not break any test.

diff --git a/op.c b/op.c
index 2dff059..7e1360c 100644 (file)
--- a/op.c
+++ b/op.c
@@ -9292,10 +9292,9 @@ Perl_ck_entersub_args_core(pTHX_ OP *entersubop, GV *namegv, SV *protosv)
     PERL_ARGS_ASSERT_CK_ENTERSUB_ARGS_CORE;
 
     if (!opnum) {
-       OP *prev, *cvop;
+       OP *cvop;
        if (!aop->op_sibling)
            aop = cUNOPx(aop)->op_first;
-       prev = aop;
        aop = aop->op_sibling;
        for (cvop = aop; cvop->op_sibling; cvop = cvop->op_sibling) ;
        if (PL_madskills) while (aop != cvop && aop->op_type == OP_STUB) {

diff --git a/pp.c b/pp.c
index c732c5b..ba337b2 100644 (file)
--- a/pp.c
+++ b/pp.c
@@ -155,12 +155,11 @@ static SV *
 S_rv2gv(pTHX_ SV *sv, const bool vivify_sv, const bool strict,
               const bool noinit)
 {
-    dSP; dVAR;
+    dVAR;
     if (!isGV(sv) || SvFAKE(sv)) SvGETMAGIC(sv);
     if (SvROK(sv)) {
        if (SvAMAGIC(sv)) {
            sv = amagic_deref_call(sv, to_gv_amg);
-           SPAGAIN;
        }
       wasref:
        sv = SvRV(sv);

diff --git a/toke.c b/toke.c
index 1bf7e18..604934e 100644 (file)
--- a/toke.c
+++ b/toke.c
@@ -6927,8 +6927,7 @@ Perl_yylex(pTHX)
 
        case KEY___FILE__:
            FUN0OP(
-               pl_yylval.opval = (OP*)newSVOP(OP_CONST, 0,
-                                       newSVpv(CopFILE(PL_curcop),0))
+               (OP*)newSVOP(OP_CONST, 0, newSVpv(CopFILE(PL_curcop),0))
            );
 
        case KEY___LINE__: