Revert "remove pessimizing moves (reported by gcc 10)"
authorAndrew Litteken <andrew.litteken@gmail.com>
Thu, 31 Dec 2020 21:13:46 +0000 (15:13 -0600)
committerAndrew Litteken <andrew.litteken@gmail.com>
Thu, 31 Dec 2020 21:14:11 +0000 (15:14 -0600)
Causing multiple different buildbots to fail with similar errors to:
http://lab.llvm.org:8011/#/builders/84/builds/3719/
http://lab.llvm.org:8011/#/builders/21/builds/5863/

This reverts commit a2513cb8655e0aea4baffb4391e946ad3e56d883.

llvm/include/llvm/ExecutionEngine/Orc/Shared/RPCUtils.h

index 63db9d4..1c8b8e0 100644 (file)
@@ -1510,20 +1510,20 @@ public:
             Args...)) {
       detail::ResultTraits<typename Func::ReturnType>::consumeAbandoned(
           std::move(Result));
-      return Err;
+      return std::move(Err);
     }
 
     if (auto Err = this->C.send()) {
       detail::ResultTraits<typename Func::ReturnType>::consumeAbandoned(
           std::move(Result));
-      return Err;
+      return std::move(Err);
     }
 
     while (!ReceivedResponse) {
       if (auto Err = this->handleOne()) {
         detail::ResultTraits<typename Func::ReturnType>::consumeAbandoned(
             std::move(Result));
-        return Err;
+        return std::move(Err);
       }
     }