spinner: crash issue on deletion fix
authorChunEon Park <hermet@hermet.pe.kr>
Fri, 28 Mar 2014 02:52:21 +0000 (11:52 +0900)
committerChunEon Park <hermet@hermet.pe.kr>
Fri, 28 Mar 2014 02:54:02 +0000 (11:54 +0900)
Summary:
Issue: longpress timer callback if it gets called after widget deletion,  crash happens.
Solution: delete the long press timer in smart del function.
Signed-off by: Kumar Navneet (k.navneet@samsung.com)
Signed-off by: Shilpa Singh (shilpa.singh@samsung.com)

Test Plan: When we tap inc/dec fast and delete the widget immediately, crash might happen.

Reviewers: raster, seoz, Hermet

Reviewed By: Hermet

CC: govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D669

@fix

src/lib/elm_spinner.c

index ae52e119f7ae8aa296618878ffad9930005dacdd..2f62fff03c1c078fab7a89d190d79864d07ba861 100644 (file)
@@ -759,6 +759,7 @@ _elm_spinner_smart_del(Eo *obj, void *_pd, va_list *list EINA_UNUSED)
    eina_stringshare_del(sd->label);
    ecore_timer_del(sd->delay_change_timer);
    ecore_timer_del(sd->spin_timer);
+   ecore_timer_del(sd->longpress_timer);
 
    if (sd->special_values)
      {