PCI: vmd: Create feature grouping for client products
authorDavid E. Box <david.e.box@linux.intel.com>
Fri, 20 Jan 2023 03:15:21 +0000 (19:15 -0800)
committerLorenzo Pieralisi <lpieralisi@kernel.org>
Thu, 2 Feb 2023 15:02:34 +0000 (16:02 +0100)
Simplify the device ID list by creating a grouping of features shared by
client products.

Suggested-by: Jon Derrick <jonathan.derrick@linux.dev>
Link: https://lore.kernel.org/r/20230120031522.2304439-4-david.e.box@linux.intel.com
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
drivers/pci/controller/vmd.c

index 1fc3f21..47fa3e5 100644 (file)
@@ -68,6 +68,10 @@ enum vmd_features {
        VMD_FEAT_CAN_BYPASS_MSI_REMAP           = (1 << 4),
 };
 
+#define VMD_FEATS_CLIENT       (VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |     \
+                                VMD_FEAT_HAS_BUS_RESTRICTIONS |        \
+                                VMD_FEAT_OFFSET_FIRST_VECTOR)
+
 static DEFINE_IDA(vmd_instance_ida);
 
 /*
@@ -1024,29 +1028,17 @@ static const struct pci_device_id vmd_ids[] = {
                                VMD_FEAT_HAS_BUS_RESTRICTIONS |
                                VMD_FEAT_CAN_BYPASS_MSI_REMAP,},
        {PCI_VDEVICE(INTEL, 0x467f),
-               .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
-                               VMD_FEAT_HAS_BUS_RESTRICTIONS |
-                               VMD_FEAT_OFFSET_FIRST_VECTOR,},
+               .driver_data = VMD_FEATS_CLIENT,},
        {PCI_VDEVICE(INTEL, 0x4c3d),
-               .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
-                               VMD_FEAT_HAS_BUS_RESTRICTIONS |
-                               VMD_FEAT_OFFSET_FIRST_VECTOR,},
+               .driver_data = VMD_FEATS_CLIENT,},
        {PCI_VDEVICE(INTEL, 0xa77f),
-               .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
-                               VMD_FEAT_HAS_BUS_RESTRICTIONS |
-                               VMD_FEAT_OFFSET_FIRST_VECTOR,},
+               .driver_data = VMD_FEATS_CLIENT,},
        {PCI_VDEVICE(INTEL, 0x7d0b),
-               .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
-                               VMD_FEAT_HAS_BUS_RESTRICTIONS |
-                               VMD_FEAT_OFFSET_FIRST_VECTOR,},
+               .driver_data = VMD_FEATS_CLIENT,},
        {PCI_VDEVICE(INTEL, 0xad0b),
-               .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
-                               VMD_FEAT_HAS_BUS_RESTRICTIONS |
-                               VMD_FEAT_OFFSET_FIRST_VECTOR,},
+               .driver_data = VMD_FEATS_CLIENT,},
        {PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_VMD_9A0B),
-               .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
-                               VMD_FEAT_HAS_BUS_RESTRICTIONS |
-                               VMD_FEAT_OFFSET_FIRST_VECTOR,},
+               .driver_data = VMD_FEATS_CLIENT,},
        {0,}
 };
 MODULE_DEVICE_TABLE(pci, vmd_ids);