scsi: fnic: Use vzalloc()

Use vzalloc() instead of hand writing it with vmalloc()+memset().  This is
less verbose.

This also fixes some style issues :)

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/a1179941a6d440140513e681f4f3a1b92c8d83ae.1685210773.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c
index 6fedc3b..c4d9ed0 100644 (file)
--- a/drivers/scsi/fnic/fnic_debugfs.c
+++ b/drivers/scsi/fnic/fnic_debugfs.c
@@ -201,25 +201,21 @@ static int fnic_trace_debugfs_open(struct inode *inode,
                return -ENOMEM;
 
        if (*rdata_ptr == fc_trc_flag->fnic_trace) {
-               fnic_dbg_prt->buffer = vmalloc(array3_size(3, trace_max_pages,
+               fnic_dbg_prt->buffer = vzalloc(array3_size(3, trace_max_pages,
                                                           PAGE_SIZE));
                if (!fnic_dbg_prt->buffer) {
                        kfree(fnic_dbg_prt);
                        return -ENOMEM;
                }
-               memset((void *)fnic_dbg_prt->buffer, 0,
-               3 * (trace_max_pages * PAGE_SIZE));
                fnic_dbg_prt->buffer_len = fnic_get_trace_data(fnic_dbg_prt);
        } else {
                fnic_dbg_prt->buffer =
-                       vmalloc(array3_size(3, fnic_fc_trace_max_pages,
+                       vzalloc(array3_size(3, fnic_fc_trace_max_pages,
                                            PAGE_SIZE));
                if (!fnic_dbg_prt->buffer) {
                        kfree(fnic_dbg_prt);
                        return -ENOMEM;
                }
-               memset((void *)fnic_dbg_prt->buffer, 0,
-                       3 * (fnic_fc_trace_max_pages * PAGE_SIZE));
                fnic_dbg_prt->buffer_len =
                        fnic_fc_trace_get_data(fnic_dbg_prt, *rdata_ptr);
        }