NFC: pn533: change order of free_irq and dev unregistration
authorAndrey Rusalin <arusalin@dev.rtsoft.ru>
Wed, 28 Dec 2016 17:10:57 +0000 (20:10 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Mar 2018 08:17:46 +0000 (09:17 +0100)
[ Upstream commit 068a496c4525c638ffab56449d905b88ef97fe32 ]

Change order of free_irq and dev unregistration.
It fixes situation when device already unregistered and
an interrupt happens and nobody can handle it.

Signed-off-by: Andrey Rusalin <arusalin@dev.rtsoft.ru>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nfc/pn533/i2c.c

index 1dc8924..11d78b4 100644 (file)
@@ -242,10 +242,10 @@ static int pn533_i2c_remove(struct i2c_client *client)
 
        dev_dbg(&client->dev, "%s\n", __func__);
 
-       pn533_unregister_device(phy->priv);
-
        free_irq(client->irq, phy);
 
+       pn533_unregister_device(phy->priv);
+
        return 0;
 }