elm_popup: remove on_show_region_set call
authorMarcel Hollerbach <mail@marcel-hollerbach.de>
Thu, 28 Feb 2019 13:48:37 +0000 (08:48 -0500)
committerWonki Kim <wonki_.kim@samsung.com>
Fri, 8 Mar 2019 11:49:36 +0000 (20:49 +0900)
Summary:
Its hard to say why removing such calls are fixing a bug like T7274.
However, it appears that this call causes the min size calculation of
evas to fall apart. This also removes a workarround introduced earlier
to fix this.

This fixes T7274

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7274

Differential Revision: https://phab.enlightenment.org/D8043

src/lib/elementary/elc_popup.c
src/lib/elementary/elm_scroller.c

index e33a04f..376f0a6 100644 (file)
@@ -806,14 +806,6 @@ _elm_popup_elm_layout_sizing_eval(Eo *obj, Elm_Popup_Data *sd)
         sd->allow_eval = EINA_TRUE;
         /* END */
 
-        if (sd->main_layout)
-          {
-             Evas *ev = evas_object_evas_get(sd->main_layout);
-             if (evas_smart_objects_calculating_get(ev))
-               evas_object_smart_calculate(sd->main_layout);
-             else
-               evas_object_smart_need_recalculate_set(sd->main_layout, EINA_TRUE);
-          }
        return;
      }
 
index 08b2bd4..39ac0b3 100644 (file)
@@ -1156,11 +1156,6 @@ _focused_element(void *data, const Efl_Event *event)
    geom.y = geom.y + pan_y - pos.y;
 
    elm_interface_scrollable_region_bring_in(obj, geom.x, geom.y, geom.w, geom.h);
-
-   geom = efl_gfx_entity_geometry_get(obj);
-   geom.x = geom.y = 0;
-   elm_widget_show_region_set(obj, geom, EINA_TRUE);
-
 }
 
 EOLIAN static Eo *