projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0e3cea7
)
gen_stats: Stop using NLA_PUT*().
author
David S. Miller
<davem@davemloft.net>
Mon, 2 Apr 2012 00:47:35 +0000
(20:47 -0400)
committer
David S. Miller
<davem@davemloft.net>
Mon, 2 Apr 2012 08:33:44 +0000
(
04:33
-0400)
These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/gen_stats.c
patch
|
blob
|
history
diff --git
a/net/core/gen_stats.c
b/net/core/gen_stats.c
index
0452eb2
..
ddedf21
100644
(file)
--- a/
net/core/gen_stats.c
+++ b/
net/core/gen_stats.c
@@
-27,7
+27,8
@@
static inline int
gnet_stats_copy(struct gnet_dump *d, int type, void *buf, int size)
{
- NLA_PUT(d->skb, type, size, buf);
+ if (nla_put(d->skb, type, size, buf))
+ goto nla_put_failure;
return 0;
nla_put_failure: