pwm: ab8500: Simplify using devm_pwmchip_add()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 7 Jul 2021 16:28:00 +0000 (18:28 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 2 Sep 2021 19:38:40 +0000 (21:38 +0200)
This allows to drop the platform_driver's remove function. This is the
only user of driver data so this can go away, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-ab8500.c

index 281f74a..ad37bc4 100644 (file)
@@ -111,26 +111,11 @@ static int ab8500_pwm_probe(struct platform_device *pdev)
        ab8500->chip.npwm = 1;
        ab8500->hwid = pdev->id - 1;
 
-       err = pwmchip_add(&ab8500->chip);
+       err = devm_pwmchip_add(&pdev->dev, &ab8500->chip);
        if (err < 0)
                return dev_err_probe(&pdev->dev, err, "Failed to add pwm chip\n");
 
        dev_dbg(&pdev->dev, "pwm probe successful\n");
-       platform_set_drvdata(pdev, ab8500);
-
-       return 0;
-}
-
-static int ab8500_pwm_remove(struct platform_device *pdev)
-{
-       struct ab8500_pwm_chip *ab8500 = platform_get_drvdata(pdev);
-       int err;
-
-       err = pwmchip_remove(&ab8500->chip);
-       if (err < 0)
-               return err;
-
-       dev_dbg(&pdev->dev, "pwm driver removed\n");
 
        return 0;
 }
@@ -140,7 +125,6 @@ static struct platform_driver ab8500_pwm_driver = {
                .name = "ab8500-pwm",
        },
        .probe = ab8500_pwm_probe,
-       .remove = ab8500_pwm_remove,
 };
 module_platform_driver(ab8500_pwm_driver);