tools/power/x86/intel-speed-select: Fix display for turbo-freq auto mode
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Fri, 31 Jan 2020 05:45:17 +0000 (21:45 -0800)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 10 Feb 2020 15:47:38 +0000 (17:47 +0200)
When mailbox command for the turbo-freq enable fails, then don't display
result for auto-mode. When turbo-freq enable fails, there is no point
to set CPU priorities.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
tools/power/x86/intel-speed-select/isst-config.c

index 2b2b816..0cf3548 100644 (file)
@@ -42,6 +42,7 @@ static int out_format_json;
 static int cmd_help;
 static int force_online_offline;
 static int auto_mode;
+static int fact_enable_fail;
 
 /* clos related */
 static int current_clos = -1;
@@ -1527,6 +1528,8 @@ static void set_fact_for_cpu(int cpu, void *arg1, void *arg2, void *arg3,
 disp_results:
        if (status) {
                isst_display_result(cpu, outf, "turbo-freq", "enable", ret);
+               if (ret)
+                       fact_enable_fail = ret;
        } else {
                /* Since we modified TRL during Fact enable, restore it */
                isst_set_trl_from_current_tdp(cpu, fact_trl);
@@ -1568,7 +1571,7 @@ static void set_fact_enable(int arg)
                                               NULL, &enable);
        isst_ctdp_display_information_end(outf);
 
-       if (enable && auto_mode) {
+       if (!fact_enable_fail && enable && auto_mode) {
                /*
                 * When we adjust CLOS param, we have to set for siblings also.
                 * So for the each user specified CPU, also add the sibling