staging: speakup: Use time_after_eq to compare jiffies in speakup_keypc.c
authorEsra Altintas <es.altintas@gmail.com>
Wed, 8 Oct 2014 11:32:10 +0000 (14:32 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Oct 2014 02:29:19 +0000 (10:29 +0800)
The following patch fixes the checkpatch.pl warning:
WARNING: Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends

Signed-off-by: Esra Altintas <es.altintas@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/speakup/speakup_keypc.c

index 4ed3889..cef20fd 100644 (file)
@@ -229,7 +229,7 @@ spin_lock_irqsave(&speakup_info.spinlock, flags);
                        ch = PROCSPEECH;
                outb_p(ch, synth_port);
                SWAIT;
-               if ((jiffies >= jiff_max) && (ch == SPACE)) {
+               if (time_after_eq(jiffies, jiff_max) && (ch == SPACE)) {
                        timeout = 1000;
                        while (synth_writable())
                                if (--timeout <= 0)